Subject: Re: [PATCH net-next-2.6] skge: add GRO support

From: Stephen Hemminger <[email-masked]>
Date: Tue, 31 Aug 2010 18:31:05 -0700

On Wed, 01 Sep 2010 00:32:36 +0200
Eric Dumazet <[email-masked]> wrote:

> @@ -3193,7 +3192,7 @@ static int skge_poll(struct napi_struct *napi, int to_do)
>  		unsigned long flags;
>  
>  		spin_lock_irqsave(&hw->hw_lock, flags);
> -		__napi_complete(napi);
> +		napi_complete(napi);

This adds a redundant irq_save/irq_restore in the packet
receive path.

In the case of skge, since the both ports share a single
IRQ mask register, the lock is there to make sure that updates
to the mask register doesn't race between NAPI finishing
on one port and IRQ on other port changing same IRQ mask register.