Subject: Re: [PATCH] drivers/net/pch_gbe: Cleanup stats use

From: Stephen Hemminger <[email-masked]>
Date: Tue, 31 Aug 2010 18:33:31 -0700

On Tue, 31 Aug 2010 11:38:35 -0700
Joe Perches <[email-masked]> wrote:

>  struct pch_gbe_stats {
> -	signed char stat_string[ETH_GSTRING_LEN];
> -	int sizeof_stat;
> -	int stat_offset;
> +	signed char string[ETH_GSTRING_LEN];
> +	size_t size;
> +	size_t offset;
>  };

Is this driver really using 'signed char' here?
Should just be 'char' for a simple string.