Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

From: Stephen Hemminger <[email-masked]>
Date: Wed, 8 Sep 2010 07:55:45 -0700

On Wed, 08 Sep 2010 16:16:11 +0200
Jiri Slaby <[email-masked]> wrote:

> >>> +
> >>> + rxdr->count = max(ring->rx_pending, (u32) PCH_GBE_MIN_RXD);
> >>> + rxdr->count = min(rxdr->count, (u32) PCH_GBE_MAX_RXD);  
> >>
> >> clamp()
> >> And why you need the cast?  
> > 
> > [masa]
> > Since warning appears at the time of a make.  
> 
> OK, then you have type error which you should fix instead. Perhaps
> define the constnts with U suffix?

Better yet:
	rxdr->count = clamp_val(ring->rx_pending,
				PCH_GBE_MIN_RXD,
				PCH_GBE_MAX_RXD);