Subject: Re: [RFC PATCH 1/4] Add a new API to virtio-pci

From: Rusty Russell <[email-masked]>
Date: Thu, 9 Sep 2010 13:19:39 +0930

On Wed, 8 Sep 2010 04:59:05 pm Krishna Kumar wrote:
> Add virtio_get_queue_index() to get the queue index of a
> vq.  This is needed by the cb handler to locate the queue
> that should be processed.

This seems a bit weird.  I mean, the driver used vdev->config->find_vqs
to find the queues, which returns them (in order).  So, can't you put this
into your struct send_queue?

Also, why define VIRTIO_MAX_TXQS?  If the driver can't handle all of them,
it should simply not use them...

Thanks!
Rusty.