From: Andrew Morton <akpm@linux-foundation•org>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, bugzilla-daemon@bugzilla•kernel.org,
bugme-daemon@bugzilla•kernel.org, bono@onlinehome•de
Subject: Re: [Bugme-new] [Bug 16603] New: send of data > 4 GB fails on 64 bit systems
Date: Mon, 27 Sep 2010 20:56:24 -0700 [thread overview]
Message-ID: <20100927205624.1564649e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100927.202425.71120040.davem@davemloft.net>
On Mon, 27 Sep 2010 20:24:25 -0700 (PDT) David Miller <davem@davemloft•net> wrote:
> Ok, I suspect the following is enough to fix this specific bug
> report, TCP sending.
>
> However, as I stated in my previous reply there are creepy
> crawlies all over the place.
>
> For example, all of the routines in net/core/iovec.c (memcpy_toiovec,
> memcpy_toiovecend, memcpy_fromiovec, memcpy_fromiovecend,
> csum_partial_copy_fromiovecend) that cast using min_t() are currently
> casting "down" to "unsigned int".
>
> They should probably case "up" to "size_t".
eep.
A blanket suckyfix might be, at the syscall level:
if (size > 4g) {
do_it_in_4g_hunks();
do_the_last_bit();
}
unless that would break some networking syscall->framesize guarantees
or something?
And such a "fix" would make it hard to test the real fix!
I'm surprised that this issue hasn't come up before.
next prev parent reply other threads:[~2010-09-28 3:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-16603-10286@https.bugzilla.kernel.org/>
2010-09-27 23:15 ` [Bugme-new] [Bug 16603] New: send of data > 4 GB fails on 64 bit systems Andrew Morton
2010-09-28 2:41 ` David Miller
2010-09-28 3:24 ` David Miller
2010-09-28 3:56 ` Andrew Morton [this message]
2010-09-28 4:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927205624.1564649e.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=bono@onlinehome$(echo .)de \
--cc=bugme-daemon@bugzilla$(echo .)kernel.org \
--cc=bugzilla-daemon@bugzilla$(echo .)kernel.org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox