From: "Matt Carlson" <mcarlson@broadcom•com>
To: "David Miller" <davem@davemloft•net>
Cc: "Matthew Carlson" <mcarlson@broadcom•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"andy@greyhouse•net" <andy@greyhouse•net>
Subject: Re: [PATCH net-next 0/8] tg3: Bugfixes and updates
Date: Fri, 1 Oct 2010 10:25:45 -0700 [thread overview]
Message-ID: <20101001172545.GA17223@mcarlson.broadcom.com> (raw)
In-Reply-To: <20101001.002628.267960834.davem@davemloft.net>
On Fri, Oct 01, 2010 at 12:26:28AM -0700, David Miller wrote:
> From: "Matt Carlson" <mcarlson@broadcom•com>
> Date: Thu, 30 Sep 2010 13:34:29 -0700
>
> > This patchset implements some bugfixes, removes the 5724 device
> > ID and introduces extended rx buffer rings.
>
> All applied....
>
> But really, I want to hear some real justification for a 2048 entry RX
> ring at gigabit speeds. I even think 512 is way too large for gigabit
> parts.
I don't have any personal experience where a larger ring size could
benefit. However, I have heard of situations in the past where people
have said increasing the amount of rx buffers available has smoothed
over some bursty traffic / cpu usage patterns. These people really did
want more than 512 rx buffers.
> Any machine that gets one of these newer 5717 parts does not need that
> much queueing, and too deep queues tend to hurt locality and thus
> performance.
Good point. I'll see if we can scale the BD ring size based on the
number of rx buffers the administrator has configured.
prev parent reply other threads:[~2010-10-01 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 20:34 [PATCH net-next 0/8] tg3: Bugfixes and updates Matt Carlson
2010-10-01 7:26 ` David Miller
2010-10-01 17:25 ` Matt Carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001172545.GA17223@mcarlson.broadcom.com \
--to=mcarlson@broadcom$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox