public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: akpm@linux-foundation•org
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, akpm@linux-foundation•org,
	schwidefsky@de•ibm.com, heiko.carstens@de•ibm.com,
	peppe.cavallaro@st•com
Subject: [patch 2/2] drivers/net/stmmac/: add HAS_IOMEM dependency
Date: Fri, 01 Oct 2010 14:17:13 -0700	[thread overview]
Message-ID: <201010012117.o91LHDCF021161@imap1.linux-foundation.org> (raw)

From: Martin Schwidefsky <schwidefsky@de•ibm.com>

The stmmac driver does not compile on s390:

drivers/net/stmmac/stmmac_main.c: In function 'stmmac_adjust_link':
drivers/net/stmmac/stmmac_main.c:210: error: implicit declaration of function 'readl'
drivers/net/stmmac/stmmac_main.c:263: error: implicit declaration of function 'writel'
drivers/net/stmmac/stmmac_main.c: In function 'stmmac_dvr_probe':
drivers/net/stmmac/stmmac_main.c:1674: error: implicit declaration of function 'ioremap'
drivers/net/stmmac/stmmac_main.c:1674: warning: assignment makes pointer from integer without a cast
drivers/net/stmmac/stmmac_main.c:1761: error: implicit declaration of function 'iounmap'
make[3]: *** [drivers/net/stmmac/stmmac_main.o] Error 1

Signed-off-by: Martin Schwidefsky <schwidefsky@de•ibm.com>
Cc: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
Cc: David S. Miller <davem@davemloft•net>
Cc: Heiko Carstens <heiko.carstens@de•ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation•org>
---

 drivers/net/stmmac/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/net/stmmac/Kconfig~drivers-net-stmmac-add-has_iomem-dependency drivers/net/stmmac/Kconfig
--- a/drivers/net/stmmac/Kconfig~drivers-net-stmmac-add-has_iomem-dependency
+++ a/drivers/net/stmmac/Kconfig
@@ -3,7 +3,7 @@ config STMMAC_ETH
 	select MII
 	select PHYLIB
 	select CRC32
-	depends on NETDEVICES
+	depends on NETDEVICES && HAS_IOMEM
 	help
 	  This is the driver for the Ethernet IPs are built around a
 	  Synopsys IP Core and only tested on the STMicroelectronics
_

             reply	other threads:[~2010-10-01 21:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-01 21:17 akpm [this message]
2010-10-04  5:00 ` [patch 2/2] drivers/net/stmmac/: add HAS_IOMEM dependency David Miller
2010-10-05 10:46   ` Peppe CAVALLARO
2010-10-05 18:41     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010012117.o91LHDCF021161@imap1.linux-foundation.org \
    --to=akpm@linux-foundation$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=heiko.carstens@de$(echo .)ibm.com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=peppe.cavallaro@st$(echo .)com \
    --cc=schwidefsky@de$(echo .)ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox