From: Florian Mickler <florian@mickler•org>
To: "Guy, Wey-Yi" <wey-yi.w.guy@intel•com>
Cc: Stanislaw Gruszka <sgruszka@redhat•com>,
"linville@tuxdriver•com" <linville@tuxdriver•com>,
"stable@kernel•org" <stable@kernel•org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"Chatre, Reinette" <reinette.chatre@intel•com>,
"ilw@linux•intel.com" <ilw@linux•intel.com>,
"Berg, Johannes" <johannes.berg@intel•com>,
"Cahill, Ben M" <ben.m.cahill@intel•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH wireless-2.6 or stable] iwlwifi: return error when fail to start scanning
Date: Wed, 6 Oct 2010 19:32:45 +0200 [thread overview]
Message-ID: <20101006193245.698957cc@schatten.dmk.lab> (raw)
In-Reply-To: <1286381578.12594.18.camel@wwguy-ubuntu>
On Wed, 06 Oct 2010 09:12:58 -0700
"Guy, Wey-Yi" <wey-yi.w.guy@intel•com> wrote:
> Hi Gruszka,
>
> On Wed, 2010-10-06 at 09:04 -0700, Stanislaw Gruszka wrote:
> > This is stable friendly backport of wireless-testing commit
> > 3eecce527c7434dfd16517ce08b49632c8a26717 "iwlwifi: unify scan start
> > checks". Wireless-testing version include also a lot of cleanups.
> >
> > On error case in {iwl3945,iwlagn}_request_scan we queue abort_scan work,
> > which in a fact do nothing, so we never complete the scan. Thats gives
> > "WARNING: at net/wireless/core.c:614 wdev_cleanup_work" and stopped
> > network connection until reload iwlwifi modules. Return of -EIO, and
> > stopping queuing any work is a fix.
> >
> > Note there are still many cases when we can get:
> >
> > WARNING: at net/wireless/core.c:614 wdev_cleanup_work
> > WARNING: at net/mac80211/scan.c:266 ieee80211_scan_completed
> > WARNING: at net/mac80211/scan.c:269 ieee80211_scan_complete
> >
> > which are not fixed. Unfortunately does not exist single, small fix
> > for that problems, and we probably will see some more bug reports
> > with scan warnings. As solution we rewrite iwl-scan.c code to avoid
> > all possible race conditions. That quite big patch set is queued
> > for 2.6.37 .
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat•com>
> > ---
> > Patch is intended for wireless-2.6, or in case when it does not
> > make 2.6.36 release, for -stable 2.6.36.y
> >
>
> Is this the replacement for Mickler's patch?
>
> Thanks
> Wey
>
This is on top of current mainline, as far as I see. (And it replaces
the patch I sent few hours ago)
Regards,
Flo
next prev parent reply other threads:[~2010-10-06 17:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 6:43 Fw: [PATCH] iwl3945: queue the right work if the scan needs to be aborted Florian Mickler
[not found] ` <20101005084305.52a31ed4-mGsOIKOveelVRbCss4o9kg@public.gmane.org>
2010-10-05 8:57 ` Stanislaw Gruszka
2010-10-05 10:12 ` Florian Mickler
[not found] ` <20101005121242.79cdafc2-mGsOIKOveelVRbCss4o9kg@public.gmane.org>
2010-10-05 10:43 ` Stanislaw Gruszka
[not found] ` <20101005104357.GB18833-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-05 22:29 ` Florian Mickler
[not found] ` <20101005085717.GA18012-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-05 22:21 ` [PATCH] iwlwifi: fix iwlwifi scanning corner cases Florian Mickler
[not found] ` <1286317292-10679-1-git-send-email-florian-sVu6HhrpSfRAfugRpC6u6w@public.gmane.org>
2010-10-06 9:02 ` Stanislaw Gruszka
[not found] ` <20101006090228.GA2523-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-06 16:04 ` [PATCH wireless-2.6 or stable] iwlwifi: return error when fail to start scanning Stanislaw Gruszka
2010-10-06 16:12 ` Guy, Wey-Yi
2010-10-06 17:32 ` Florian Mickler [this message]
[not found] ` <20101006160434.GB24581-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-10-06 17:45 ` Florian Mickler
2010-10-06 17:48 ` Guy, Wey-Yi
2010-10-06 20:01 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006193245.698957cc@schatten.dmk.lab \
--to=florian@mickler$(echo .)org \
--cc=ben.m.cahill@intel$(echo .)com \
--cc=ilw@linux$(echo .)intel.com \
--cc=johannes.berg@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linville@tuxdriver$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=reinette.chatre@intel$(echo .)com \
--cc=sgruszka@redhat$(echo .)com \
--cc=stable@kernel$(echo .)org \
--cc=wey-yi.w.guy@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox