From: "Matt Carlson" <mcarlson@broadcom•com>
To: "Ben Hutchings" <bhutchings@solarflare•com>
Cc: "Matthew Carlson" <mcarlson@broadcom•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"andy@greyhouse•net" <andy@greyhouse•net>
Subject: Re: [PATCH net-next 4/8] tg3: Add EEE support
Date: Fri, 15 Oct 2010 11:19:04 -0700 [thread overview]
Message-ID: <20101015181904.GA1389@mcarlson.broadcom.com> (raw)
In-Reply-To: <1287152246.2267.14.camel@achroite.uk.solarflarecom.com>
On Fri, Oct 15, 2010 at 07:17:26AM -0700, Ben Hutchings wrote:
> On Thu, 2010-10-14 at 13:37 -0700, Matt Carlson wrote:
> > This patch adds Energy Efficient Ethernet (EEE) support for the 5718
> > device ID and the 57765 B0 asic revision.
> [...]
> > +/* Clause 45 expansion registers */
> > +#define TG3_CL45_D7_EEEADV_CAP 0x003c
> > +#define TG3_CL45_D7_EEEADV_CAP_100TX 0x0002
> > +#define TG3_CL45_D7_EEEADV_CAP_1000T 0x0004
>
> I assume this is going to be a standard register, so I think it should
> be defined in <linux/mdio.h>.
O.K. I'll make the change and respin this patch.
> > +#define TG3_CL45_D7_EEERES_STAT 0x803e
> > +#define TG3_CL45_D7_EEERES_STAT_LP_100TX 0x0002
> > +#define TG3_CL45_D7_EEERES_STAT_LP_1000T 0x0004
>
> 0x803e not 0x003e?
I'm checking on this one. EEE works with this patch in place. Maybe I
can make this a definition that takes a standard clause 45 register as
an input though.
> Also Dave suggested there should be an ethtool interface to control EEE
> <http://thread.gmane.org/gmane.linux.network/164141/focus=165143>.
I don't see any ETH_FLAG definition for this in ethtool.h yet. Is this
the way everyone wanted to go?
prev parent reply other threads:[~2010-10-15 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 20:37 [PATCH net-next 4/8] tg3: Add EEE support Matt Carlson
2010-10-15 14:17 ` Ben Hutchings
2010-10-15 18:19 ` Matt Carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015181904.GA1389@mcarlson.broadcom.com \
--to=mcarlson@broadcom$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox