From: Stephen Hemminger <shemminger@vyatta•com>
To: Divy Le Ray <divy@chelsio•com>,
"David S. Miller" <davem@davemloft•net>,
Casey Leedom <leedom@chelsio•com>,
Dimitris Michailidis <dm@chelsio•com>
Cc: netdev@vger•kernel.org
Subject: [PATCH 3/3] cxgb4vf: function namespace cleanup
Date: Fri, 15 Oct 2010 15:43:12 -0700 [thread overview]
Message-ID: <20101015224523.727651263@vyatta.com> (raw)
In-Reply-To: 20101015224309.179898823@vyatta.com
[-- Attachment #1: cxgb4vf-local.patch --]
[-- Type: text/plain, Size: 2603 bytes --]
Where possible make functions local.
Compile tested only
Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
---
drivers/net/cxgb4vf/sge.c | 6 +++---
drivers/net/cxgb4vf/t4vf_common.h | 1 -
drivers/net/cxgb4vf/t4vf_hw.c | 4 ++--
3 files changed, 5 insertions(+), 6 deletions(-)
--- a/drivers/net/cxgb4vf/sge.c 2010-10-15 13:35:37.841741143 -0700
+++ b/drivers/net/cxgb4vf/sge.c 2010-10-15 13:37:26.753998981 -0700
@@ -1361,7 +1361,7 @@ out_free:
* Releases the pages of a packet gather list. We do not own the last
* page on the list and do not free it.
*/
-void t4vf_pktgl_free(const struct pkt_gl *gl)
+static void t4vf_pktgl_free(const struct pkt_gl *gl)
{
int frag;
@@ -1636,7 +1636,7 @@ static inline void rspq_next(struct sge_
* on this queue. If the system is under memory shortage use a fairly
* long delay to help recovery.
*/
-int process_responses(struct sge_rspq *rspq, int budget)
+static int process_responses(struct sge_rspq *rspq, int budget)
{
struct sge_eth_rxq *rxq = container_of(rspq, struct sge_eth_rxq, rspq);
int budget_left = budget;
@@ -1888,7 +1888,7 @@ static unsigned int process_intrq(struct
* The MSI interrupt handler handles data events from SGE response queues as
* well as error and other async events as they all use the same MSI vector.
*/
-irqreturn_t t4vf_intr_msi(int irq, void *cookie)
+static irqreturn_t t4vf_intr_msi(int irq, void *cookie)
{
struct adapter *adapter = cookie;
--- a/drivers/net/cxgb4vf/t4vf_common.h 2010-10-15 13:38:12.555553059 -0700
+++ b/drivers/net/cxgb4vf/t4vf_common.h 2010-10-15 13:38:30.716055176 -0700
@@ -235,7 +235,6 @@ static inline int t4vf_wr_mbox_ns(struct
int __devinit t4vf_wait_dev_ready(struct adapter *);
int __devinit t4vf_port_init(struct adapter *, int);
-int t4vf_query_params(struct adapter *, unsigned int, const u32 *, u32 *);
int t4vf_set_params(struct adapter *, unsigned int, const u32 *, const u32 *);
int t4vf_get_sge_params(struct adapter *);
--- a/drivers/net/cxgb4vf/t4vf_hw.c 2010-10-15 13:35:44.638006598 -0700
+++ b/drivers/net/cxgb4vf/t4vf_hw.c 2010-10-15 13:38:04.503330665 -0700
@@ -335,8 +335,8 @@ int __devinit t4vf_port_init(struct adap
* Reads the values of firmware or device parameters. Up to 7 parameters
* can be queried at once.
*/
-int t4vf_query_params(struct adapter *adapter, unsigned int nparams,
- const u32 *params, u32 *vals)
+static int t4vf_query_params(struct adapter *adapter, unsigned int nparams,
+ const u32 *params, u32 *vals)
{
int i, ret;
struct fw_params_cmd cmd, rpl;
prev parent reply other threads:[~2010-10-15 23:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 22:43 [PATCH 0/3] Chelsio driver namespace cleanups Stephen Hemminger
2010-10-15 22:43 ` [PATCH 1/3] cxgb3: function namespace cleanup Stephen Hemminger
2010-10-19 1:14 ` Divy Le Ray
2010-10-21 14:19 ` David Miller
2010-10-15 22:43 ` [PATCH 2/3] cxgb4: " Stephen Hemminger
2010-10-15 23:29 ` Joe Perches
2010-10-15 23:50 ` Stephen Hemminger
2010-10-15 23:34 ` Dimitris Michailidis
2010-10-16 0:10 ` [PATCH 2/3] cxgb4: function namespace cleanup (v2) Stephen Hemminger
2010-10-16 1:11 ` Dimitris Michailidis
2010-10-16 4:23 ` Stephen Hemminger
2010-10-16 6:16 ` Dimitris Michailidis
2010-10-17 3:30 ` Steve Wise
2010-10-18 14:31 ` David Miller
2010-10-18 15:39 ` [PATCH 2/3] cxgb4: function namespace cleanup (v3) Stephen Hemminger
2010-10-18 23:16 ` Dimitris Michailidis
2010-10-21 11:30 ` David Miller
2010-10-18 14:47 ` [PATCH 2/3] cxgb4: function namespace cleanup (v2) Stephen Hemminger
2010-10-18 14:53 ` Steve Wise
2010-10-15 22:43 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015224523.727651263@vyatta.com \
--to=shemminger@vyatta$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=divy@chelsio$(echo .)com \
--cc=dm@chelsio$(echo .)com \
--cc=leedom@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox