Subject: Re: [PATCH] net: unix: make some variables constant

From: Stephen Hemminger <[email-masked]>
Date: Mon, 18 Oct 2010 23:03:22 -0700

On Tue, 19 Oct 2010 13:24:02 +0800
Changli Gao <[email-masked]> wrote:

> And since ctl_table.data is initialized later, we don't need to initialize
> the data member of the template variable unix_table.
> 
> Signed-off-by: Changli Gao <[email-masked]>
> ---
>  net/unix/sysctl_net_unix.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> diff --git a/net/unix/sysctl_net_unix.c b/net/unix/sysctl_net_unix.c
> index 397cffe..1114ccc 100644
> --- a/net/unix/sysctl_net_unix.c
> +++ b/net/unix/sysctl_net_unix.c
> @@ -15,10 +15,9 @@
>  
>  #include <net/af_unix.h>
>  
> -static ctl_table unix_table[] = {
> +const static ctl_table unix_table[] = {

Typical convention is "static const" rather than "const static"

git grep 'const static' | wc -l  => 5
git grep 'static const' | wc -l  => 18589

--