Subject: Re: [PATCH] bridge: make br_parse_ip_options static

From: Stephen Hemminger <[email-masked]>
Date: Tue, 19 Oct 2010 07:55:03 -0700

On Tue, 19 Oct 2010 07:22:34 -0400
Bandan Das <[email-masked]> wrote:

> On  0, Stephen Hemminger <[email-masked]> wrote:
> > 
> > Signed-off-by: Stephen Hemminger <[email-masked]>
> > 
> > --- a/net/bridge/br_netfilter.c	2010-10-18 17:01:36.903364885 -0700
> > +++ b/net/bridge/br_netfilter.c	2010-10-18 17:01:48.106569141 -0700
> > @@ -213,7 +213,7 @@ static inline void nf_bridge_update_prot
> >   * expected format
> >   */
> >  
> > -int br_parse_ip_options(struct sk_buff *skb)
> > +static int br_parse_ip_options(struct sk_buff *skb)
> >  {
> >  	struct ip_options *opt;
> >  	struct iphdr *iph;
> > 
> 
> My main motivation behind not making this static was that
> there would be possibly other places in the bridge code 
> (besides br_netfilter.c) where we enter the IP stack and might 
> want to call this. Not sure if it's indeed the case though..
> 

I checked by doing make allmodconfig as well as looking by
git grep 'br_parse_ip_options'

--