From: Jarek Poplawski <jarkao2@gmail•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>, emin ak <eminak71@gmail•com>,
Andrew Morton <akpm@linux-foundation•org>,
netdev@vger•kernel.org, bugzilla-daemon@bugzilla•kernel.org,
bugme-daemon@bugzilla•kernel.org,
Anton Vorontsov <avorontsov@mvista•com>,
Andy Fleming <afleming@freescale•com>
Subject: Re: [PATCH] gianfar: Fix crashes on RX path (Was Re: [Bugme-new] [Bug 19692] New: linux-2.6.36-rc5 crash with gianfar ethernet at full line rate traffic)
Date: Fri, 22 Oct 2010 08:52:48 +0000 [thread overview]
Message-ID: <20101022085248.GA8571@ff.dom.local> (raw)
In-Reply-To: <20101022065231.GA7036@ff.dom.local>
On Fri, Oct 22, 2010 at 06:52:31AM +0000, Jarek Poplawski wrote:
> On Fri, Oct 22, 2010 at 08:11:57AM +0200, Eric Dumazet wrote:
...
> > Gianfar claims to be multiqueue, but only one cpu can run gfar_poll()
> > and call gfar_clean_tx_ring() / gfar_clean_rx_ring()
> >
> > If not, there would be more bugs than only rx_recycle thing
>
> I didn't find what prevents running gfar_poll on many cpus and don't
> claim there is no more bugs around.
On the other hand, I don't see your point in the code below either.
These're only per gfargrp queues - not per device, aren't they?
Jarek P.
>
> >
> > vi +2822 drivers/net/gianfar.c
> >
> > for_each_set_bit(i, &gfargrp->rx_bit_map, priv->num_rx_queues) {
> > if (test_bit(i, &serviced_queues))
> > continue;
> > rx_queue = priv->rx_queue[i];
> > tx_queue = priv->tx_queue[rx_queue->qindex];
> >
> > tx_cleaned += gfar_clean_tx_ring(tx_queue);
> > rx_cleaned_per_queue = gfar_clean_rx_ring(rx_queue,
> > budget_per_queue);
> > rx_cleaned += rx_cleaned_per_queue;
> > if(rx_cleaned_per_queue < budget_per_queue) {
> > left_over_budget = left_over_budget +
> > (budget_per_queue - rx_cleaned_per_queue);
> > set_bit(i, &serviced_queues);
> > num_queues--;
> > }
> > }
> >
> >
next prev parent reply other threads:[~2010-10-22 8:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-19692-10286@https.bugzilla.kernel.org/>
2010-10-04 20:53 ` [Bugme-new] [Bug 19692] New: linux-2.6.36-rc5 crash with gianfar ethernet at full line rate traffic Andrew Morton
2010-10-08 9:24 ` Jarek Poplawski
2010-10-09 12:10 ` emin ak
2010-10-10 10:32 ` Jarek Poplawski
2010-10-15 8:58 ` Jarek Poplawski
2010-10-15 23:14 ` emin ak
2010-10-16 19:48 ` Jarek Poplawski
2010-10-19 6:44 ` emin ak
2010-10-19 10:06 ` [PATCH] gianfar: Fix crashes on RX path (Was Re: [Bugme-new] [Bug 19692] New: linux-2.6.36-rc5 crash with gianfar ethernet at full line rate traffic) Jarek Poplawski
2010-10-22 5:42 ` emin ak
2010-10-22 6:14 ` Eric Dumazet
2010-10-22 7:03 ` Jarek Poplawski
2010-10-22 6:11 ` Eric Dumazet
2010-10-22 6:52 ` Jarek Poplawski
2010-10-22 8:52 ` Jarek Poplawski [this message]
2010-10-26 17:42 ` [PATCH] gianfar: Fix crashes on RX path David Miller
2010-10-26 21:20 ` Jarek Poplawski
2010-10-26 21:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022085248.GA8571@ff.dom.local \
--to=jarkao2@gmail$(echo .)com \
--cc=afleming@freescale$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=avorontsov@mvista$(echo .)com \
--cc=bugme-daemon@bugzilla$(echo .)kernel.org \
--cc=bugzilla-daemon@bugzilla$(echo .)kernel.org \
--cc=davem@davemloft$(echo .)net \
--cc=eminak71@gmail$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox