public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge•net.au>
To: Hans Schillstrom <hans.schillstrom@ericsson•com>
Cc: lvs-devel@vger•kernel.org, netdev@vger•kernel.org,
	netfilter-devel@vger•kernel.org, ja@ssi•bg, wensong@linux-vs•org,
	daniel.lezcano@free•fr
Subject: Re: [RFC PATCH 5/9] ipvs network name space aware
Date: Fri, 22 Oct 2010 21:05:48 +0200	[thread overview]
Message-ID: <20101022190548.GA24978@verge.net.au> (raw)
In-Reply-To: <201010081317.04167.hans.schillstrom@ericsson.com>

On Fri, Oct 08, 2010 at 01:17:02PM +0200, Hans Schillstrom wrote:
> This patch just contains ip_vs_ctl
> 
> Signed-off-by:Hans Schillstrom <hans.schillstrom@ericsson•com>
> 
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index ca8ec8c..7e99cbc 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c

[ snip ]

> @@ -1539,53 +1511,71 @@ proc_do_sync_threshold(ctl_table *table, int write,
> 
>  /*
>   *	IPVS sysctl table (under the /proc/sys/net/ipv4/vs/)
> + *	Do not change order or insert new entries without
> + *	align with netns init in __ip_vs_control_init()
>   */
> 
>  static struct ctl_table vs_vars[] = {
>  	{
>  		.procname	= "amemthresh",
> -		.data		= &sysctl_ip_vs_amemthresh,
> -		.maxlen		= sizeof(int),
> -		.mode		= 0644,
> -		.proc_handler	= proc_dointvec,
> -	},
> -#ifdef CONFIG_IP_VS_DEBUG
> -	{
> -		.procname	= "debug_level",
> -		.data		= &sysctl_ip_vs_debug_level,
>  		.maxlen		= sizeof(int),
>  		.mode		= 0644,
>  		.proc_handler	= proc_dointvec,
>  	},
> -#endif
>  	{
>  		.procname	= "am_droprate",
> -		.data		= &sysctl_ip_vs_am_droprate,
>  		.maxlen		= sizeof(int),
>  		.mode		= 0644,
>  		.proc_handler	= proc_dointvec,
>  	},
>  	{
>  		.procname	= "drop_entry",
> -		.data		= &sysctl_ip_vs_drop_entry,
>  		.maxlen		= sizeof(int),
>  		.mode		= 0644,
>  		.proc_handler	= proc_do_defense_mode,
>  	},
>  	{
>  		.procname	= "drop_packet",
> -		.data		= &sysctl_ip_vs_drop_packet,
>  		.maxlen		= sizeof(int),
>  		.mode		= 0644,
>  		.proc_handler	= proc_do_defense_mode,
>  	},
>  	{
>  		.procname	= "secure_tcp",
> -		.data		= &sysctl_ip_vs_secure_tcp,
>  		.maxlen		= sizeof(int),
>  		.mode		= 0644,
>  		.proc_handler	= proc_do_defense_mode,
>  	},
> +	{
> +		.procname	= "cache_bypass",
> +		.maxlen		= sizeof(int),
> +		.mode		= 0644,
> +		.proc_handler	= proc_dointvec,
> +	},
> +	{
> +		.procname	= "expire_nodest_conn",
> +		.maxlen		= sizeof(int),
> +		.mode		= 0644,
> +		.proc_handler	= proc_dointvec,
> +	},
> +	{
> +		.procname	= "expire_quiescent_template",
> +		.maxlen		= sizeof(int),
> +		.mode		= 0644,
> +		.proc_handler	= proc_dointvec,
> +	},
> +	{
> +		.procname	= "sync_threshold",
> +		.maxlen		= sizeof(sysctl_ip_vs_sync_threshold),
> +		.mode		= 0644,
> +		.proc_handler	= proc_do_sync_threshold,
> +	},
> +	{
> +		.procname	= "nat_icmp_send",
> +		.maxlen		= sizeof(int),
> +		.mode		= 0644,
> +		.proc_handler	= proc_dointvec,
> +	},
>  #if 0
>  	{
>  		.procname	= "timeout_established",

Hi Hans,

is there a reason that the order some of the entries in
vs_vars has been switched around?


  parent reply	other threads:[~2010-10-22 19:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 11:17 [RFC PATCH 5/9] ipvs network name space aware Hans Schillstrom
2010-10-20 15:21 ` Simon Horman
2010-10-21  7:35   ` Hans Schillstrom
2010-10-21  8:27     ` Horms
2010-10-21 11:16 ` Simon Horman
2010-10-21 11:26   ` Eric Dumazet
2010-10-21 11:49     ` Hans Schillstrom
2010-10-21 14:34       ` Simon Horman
2010-10-21 11:42   ` Hans Schillstrom
2010-10-21 22:56     ` Julian Anastasov
2010-10-22 19:05 ` Simon Horman [this message]
2010-10-26 13:07   ` Hans Schillstrom
2010-10-26 21:03     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101022190548.GA24978@verge.net.au \
    --to=horms@verge$(echo .)net.au \
    --cc=daniel.lezcano@free$(echo .)fr \
    --cc=hans.schillstrom@ericsson$(echo .)com \
    --cc=ja@ssi$(echo .)bg \
    --cc=lvs-devel@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=netfilter-devel@vger$(echo .)kernel.org \
    --cc=wensong@linux-vs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox