From: Ben Hutchings <bhutchings@solarflare•com>
To: David Miller <davem@davemloft•net>
Cc: somnath.kotur@emulex•com, netdev@vger•kernel.org,
linux-pci@vger•kernel.org
Subject: Re: [PATCH net-next-2.6 1/2] be2net: Adding an option to use INTx instead of MSI-X
Date: Mon, 25 Oct 2010 23:38:53 +0100 [thread overview]
Message-ID: <20101025223853.GD15074@solarflare.com> (raw)
In-Reply-To: <20101025.120943.189699949.davem@davemloft.net>
David Miller wrote:
> From: Somnath Kotur <somnath.kotur@emulex•com>
> Date: Mon, 25 Oct 2010 16:42:35 +0530
>
> > By default, be2net uses MSIx wherever possible.
> > Adding a module parameter to use INTx for users who do not want to use MSIx.
> >
> > Signed-off-by: Somnath Kotur <somnath.kotur@emulex•com>
>
> Either add a new ethtool flag, or use the PCI subsystem facilities
> for tweaking things to implement this.
>
> Do not use a module option, otherwise every other networking driver
> author will get the same "cool" idea, give the module option
> different names, and the resulting user experience is terrible.
This has already happened, sadly. So far as I can see it's mostly done
to allow users to work around systems with broken MSIs; I'm not aware of
any other reason to prefer legacy interrupts. However, the PCI subsystem
already implements a blacklist and a kernel parameter for disabling MSIs
on these systems.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-10-25 22:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 11:12 [PATCH net-next-2.6 1/2] be2net: Adding an option to use INTx instead of MSI-X Somnath Kotur
2010-10-25 19:09 ` David Miller
2010-10-25 22:38 ` Ben Hutchings [this message]
2010-10-25 23:25 ` David Miller
2010-10-26 5:24 ` Somnath.Kotur
2010-10-26 6:52 ` Michael Ellerman
2010-10-26 13:32 ` Ben Hutchings
2010-10-26 23:20 ` Michael Ellerman
2010-10-27 15:46 ` David Miller
2010-10-28 5:37 ` Grant Grundler
2010-10-27 15:45 ` David Miller
2010-10-30 23:21 ` Matthew Wilcox
2010-11-03 12:45 ` Michael Ellerman
2010-11-03 15:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025223853.GD15074@solarflare.com \
--to=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=somnath.kotur@emulex$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox