From: Ben Hutchings <bhutchings@solarflare•com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel•com>
Cc: "jgarzik@redhat•com" <jgarzik@redhat•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Wyborny, Carolyn" <carolyn.wyborny@intel•com>
Subject: Re: ethtool: missing implementation of n_priv_flags
Date: Thu, 28 Oct 2010 22:00:25 +0100 [thread overview]
Message-ID: <20101028210024.GK15074@solarflare.com> (raw)
In-Reply-To: <F169D4F5E1F1974DBFAFABF47F60C10AA5E60671@orsmsx507.amr.corp.intel.com>
Brandeburg, Jesse wrote:
> Was just looking at implementing the driver private flags to add a new feature to
> a driver.
>
> It appears that nothing in the core ethtool.c ever accesses or prints n_priv_flags,
> even if a driver assigns it (which none in the kernel currently do)
[...]
You mean net/core/ethtool.c? Or the ethtool utility?
If you set it in your get_drvinfo() operation then it will be copied out.
As for the ethtool utility, I've implemented some generic flag parsing and
printing functionality so it shouldn't be too hard to use that for private
flags.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2010-10-28 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 20:34 ethtool: missing implementation of n_priv_flags Brandeburg, Jesse
2010-10-28 21:00 ` Ben Hutchings [this message]
2010-10-28 21:10 ` Brandeburg, Jesse
2010-10-28 21:54 ` Ben Hutchings
2010-10-28 21:59 ` Jeff Garzik
2010-10-28 21:53 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028210024.GK15074@solarflare.com \
--to=bhutchings@solarflare$(echo .)com \
--cc=carolyn.wyborny@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jgarzik@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox