Subject: Re: [PATCH] jme: fix panic on load

From: "Guo-Fu Tseng" <[email-masked]>
Date: Mon, 1 Nov 2010 19:22:32 +0800

On Sun, 31 Oct 2010 09:26:36 -0700 (PDT), David Miller wrote
> From: "Guo-Fu Tseng" <[email-masked]>
> Date: Mon, 1 Nov 2010 00:39:14 +0800
> 
> > On Sun, 31 Oct 2010 16:46:18 +0100, Eric Dumazet wrote
> > Can this patch be modified to move the netif_stop_queue()
> > after register_netdev() ?
> > It seems the __QUEUE_STATE_XOFF is not set after the register_netdev.
> > The tx_queue was kcalloc() ed without touching state flags.
> 
> At the veyr moment that register_netdev() is called, the
> ->open() method of your driver can be invoked and the
> queue state changed.
> 
> So no, you can't put it after the register call.
> 
> There is zero reason to touch the queue state in your
> probe routine, the state of the queue before ->open()
> is "don't care".
> 
> Eric's patch is going to be applied, it is correct.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
I see.
Thanks for the info. :)

Guo-Fu Tseng