Subject: Re: [PATCH] net: reset gso header when the copied skb is linearized

From: Flavio Leitner <[email-masked]>
Date: Thu, 4 Nov 2010 18:35:27 -0200

On Tue, Oct 26, 2010 at 12:28:01PM -0700, David Miller wrote:
> From: Flavio Leitner <[email-masked]>
> Date: Tue, 26 Oct 2010 17:25:11 -0200
> 
> > If I understand that correctly, the gso_segs is the number
> > of GSO segments which are divided in non-linear way. When the
> > copy is made using that function, the skb turns into a big
> > one segment inlined. So, the idea of segments is lost and
> > I'm not seeing how it is going to be divided again. 
> > Later the NIC drives does, for example:
> 
> GSO has nothing to do with linearity, although it just so happens
> to be that GSO packets tend to be non-linear due to the way
> TCP builds such frames.
> 
> The GSO segment count is the number of MSS sized frames are
> contained inside of a larger than MSS sized SKB.
> 
> That is it.  So the definition and meaning is independent of
> linearity.
> 
> Thus, if we linearize a larger than MSS sized frame, it should still
> have the same GSO attributes.

It makes sense, thanks for the explanation.
Please ignore the proposed patch.

thanks again,
-- 
Flavio