Subject: Re: [PATCH 1/2] ucc_geth: Do not bring the whole IF down when TX failure.

From: Anton Vorontsov <[email-masked]>
Date: Fri, 12 Nov 2010 17:05:15 +0300

On Fri, Nov 12, 2010 at 02:55:08PM +0100, Joakim Tjernlund wrote:
> ucc_geth_close lacks a cancel_work_sync(&ugeth->timeout_work)
> to stop any outstanding processing of TX fail. However, one
> can not call cancel_work_sync without fixing the timeout function
> otherwise it will deadlock. This patch brings ucc_geth in line with
> gianfar:
> 
> Don't bring the interface down and up, just reinit controller HW
> and PHY.
> 
> Signed-off-by: Joakim Tjernlund <[email-masked]>

Looks sane, thanks!

Reviewed-by: Anton Vorontsov <[email-masked]>