From: Jarek Poplawski <jarkao2@gmail•com>
To: Evgeniy Polyakov <zbr@ioremap•net>
Cc: Nagendra Tomar <tomer_iisc@yahoo•com>,
netdev@vger•kernel.org, davem@davemloft•net,
Eric Dumazet <eric.dumazet@gmail•com>
Subject: Re: [PATCH] net-next: Fix __inet_inherit_port() to correctly increment bsockets and num_owners
Date: Mon, 29 Nov 2010 13:12:01 +0000 [thread overview]
Message-ID: <20101129131201.GB9286@ff.dom.local> (raw)
In-Reply-To: <20101129125102.GA17736@ioremap.net>
On Mon, Nov 29, 2010 at 03:51:02PM +0300, Evgeniy Polyakov wrote:
> On Mon, Nov 29, 2010 at 12:39:09PM +0000, Jarek Poplawski (jarkao2@gmail•com) wrote:
> > >> inet sockets corresponding to passive connections are added to the bind hash
> > >> using ___inet_inherit_port(). These sockets are later removed from the bind
> > >> hash using __inet_put_port(). These two functions are not exactly symmetrical.
> > >> __inet_put_port() decrements hashinfo->bsockets and tb->num_owners, whereas
> > >> ___inet_inherit_port() does not increment them. This results in both of these
> > >> going to -ve values.
> > >>
> > >> This patch fixes this by calling inet_bind_hash() from ___inet_inherit_port(),
> > >> which does the right thing.
> > >>
> > >> 'bsockets' and 'num_owners' were introduced by commit a9d8f9110d7e953c
> > >> (inet: Allowing more than 64k connections and heavily optimize bind(0))
> > >
> > > Yup, things changed from that simple patch a lot.
> > > Thanks for fixing it up.
> > > Ack.
> >
> > Probably I miss something, but since bsockets is increased by each
> > passive connection now, it seems it will trigger "hash table is full"
> > too early?
>
> Why would it? bsockets and num_owners are supposed to be increased for each
> new socket added into the table, and are used as a hint to find a bucket with
> the smallest number of sockets in it.
>
> Hash table insertion did not change, only bucket selection algorithm got
> a hint.
Evgeniy & Eric,
But it's compared to the numer of available port numbers in
inet_csk_get_port():
"if (atomic_read(&hashinfo->bsockets) > (high - low) + 1)"
Can't you have bsockets higher than this with only one port used?
Jarek P.
next prev parent reply other threads:[~2010-11-29 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-27 0:26 [PATCH] net-next: Fix __inet_inherit_port() to correctly increment bsockets and num_owners Nagendra Tomar
2010-11-27 9:02 ` Eric Dumazet
2010-11-28 23:00 ` Evgeniy Polyakov
2010-11-29 2:20 ` David Miller
2010-11-29 12:39 ` Jarek Poplawski
2010-11-29 12:49 ` Eric Dumazet
2010-11-29 12:51 ` Evgeniy Polyakov
2010-11-29 13:12 ` Jarek Poplawski [this message]
2010-11-29 13:17 ` Eric Dumazet
2010-11-29 13:33 ` Jarek Poplawski
-- strict thread matches above, loose matches on Subject: below --
2010-11-26 10:47 [PATCH] net: " Eric Dumazet
2010-11-27 0:01 ` [PATCH] net-next: " Nagendra Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129131201.GB9286@ff.dom.local \
--to=jarkao2@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tomer_iisc@yahoo$(echo .)com \
--cc=zbr@ioremap$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox