From: Sven Eckelmann <sven.eckelmann-Mmb7MZpHnFY@public•gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public•gmane.org
Subject: Re: [PATCHv6] net: Add batman-adv meshing protocol
Date: Wed, 1 Dec 2010 20:04:33 +0100 [thread overview]
Message-ID: <201012012004.34356.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <20101201.105615.48506929.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
[-- Attachment #1: Type: Text/Plain, Size: 663 bytes --]
David Miller wrote:
> From: Sven Eckelmann <sven.eckelmann-Mmb7MZpHnFY@public•gmane.org>
> Date: Wed, 1 Dec 2010 19:54:19 +0100
>
> > Do you have any more possible duplication you have in your mind right
> > now?
>
> The hashing code, for the third time.
And I asked in the past about the removal of the hashing stuff without any
reaction. So, we removed most of it. resize and iterate will be dropped too.
So, is it a problem to have a hash_find, hash_remove, hash_add? These were
created to reduce duplicated code and not to create a complete new dynamic
datastructure (which it isn't... it is just the usual hlist stuff)
thanks,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-12-01 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 13:26 [PATCHv6] net: Add batman-adv meshing protocol Sven Eckelmann
2010-12-01 18:43 ` David Miller
[not found] ` <20101201.104314.112592938.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-12-01 18:54 ` Sven Eckelmann
[not found] ` <201012011954.20275.sven.eckelmann-Mmb7MZpHnFY@public.gmane.org>
2010-12-01 18:56 ` David Miller
[not found] ` <20101201.105615.48506929.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-12-01 19:04 ` Sven Eckelmann [this message]
2010-12-01 19:12 ` David Miller
[not found] ` <20101201.111205.28818479.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-12-01 19:48 ` Marek Lindner
[not found] ` <201012012048.47096.lindner_marek-LWAfsSFWpa4@public.gmane.org>
2010-12-01 20:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012012004.34356.sven.eckelmann@gmx.de \
--to=sven.eckelmann-mmb7mzphnfy@public$(echo .)gmane.org \
--cc=b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox