From: Olof Johansson <olof@lixom•net>
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: Breno Leitao <leitao@linux•vnet.ibm.com>,
Eli Cohen <eli@dev•mellanox.co.il>,
davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [RFC] mark devices with broken LRO implementation
Date: Mon, 6 Dec 2010 11:18:16 -0600 [thread overview]
Message-ID: <20101206171816.GA25568@lixom.net> (raw)
In-Reply-To: <20101206091010.036cd78b@nehalam>
On Mon, Dec 06, 2010 at 09:10:10AM -0800, Stephen Hemminger wrote:
> The kernel uses dev_disable_lro to disable Large Receive Offload
> for cases where it is inappropriate. But several drivers do not implement
> the required hook. This is a "penalty box" patch to encourage those
> drivers to add support for the necessary ethtool set_flags.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
pasemi_mac:
Acked-by: Olof Johansson <olof@lixom•net>
> I only found three drivers that are broken. Normally, I would just fix
> them; but since changing state in the device is hardware specific, and
> I don't have the hardware or specs to do anything useful to fix it.
Thanks. All my hardware is currently in storage due to my relocation, but
I'll take a look at it when I have something to run on back. :-)
-Olof
next prev parent reply other threads:[~2010-12-06 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 16:39 [PATCH] ehea: add the correct LRO status at dev->features leitao
2010-12-06 16:48 ` Stephen Hemminger
2010-12-06 16:57 ` Breno Leitao
2010-12-06 17:10 ` [RFC] mark devices with broken LRO implementation Stephen Hemminger
2010-12-06 17:18 ` Olof Johansson [this message]
2010-12-06 17:28 ` David Miller
2010-12-06 17:58 ` Stephen Hemminger
2010-12-06 17:33 ` [PATCH] ehea: add the correct LRO status at dev->features David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206171816.GA25568@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eli@dev$(echo .)mellanox.co.il \
--cc=leitao@linux$(echo .)vnet.ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox