From: David Miller <davem@davemloft•net>
To: eric.dumazet@gmail•com
Cc: maximlevitsky@gmail•com, linux1394-devel@lists•sourceforge.net,
stefanr@s5r6•in-berlin.de, netdev@vger•kernel.org,
kuznet@ms2•inr.ac.ru, jmorris@namei•org, kaber@trash•net,
opurdila@ixiacom•com, stable@kernel•org
Subject: Re: [PATCH net-2.6] llc: fix a device refcount imbalance
Date: Wed, 08 Dec 2010 09:59:20 -0800 (PST) [thread overview]
Message-ID: <20101208.095920.229730656.davem@davemloft.net> (raw)
In-Reply-To: <1291550606.2806.237.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail•com>
Date: Sun, 05 Dec 2010 13:03:26 +0100
> [PATCH net-2.6] llc: fix a device refcount imbalance
>
> commit abf9d537fea225 (llc: add support for SO_BINDTODEVICE) added one
> refcount imbalance in llc_ui_bind(), because dev_getbyhwaddr() doesnt
> take a reference on device, while dev_get_by_index() does.
>
> Fix this using RCU locking. And since an RCU conversion will be done for
> 2.6.38 for dev_getbyhwaddr(), put the rcu_read_lock/unlock exactly at
> their final place.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail•com>
Applied and queued up for -stable.
next prev parent reply other threads:[~2010-12-08 17:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 2:09 [PATCH 0/5 V2] Firewire networking assorted fixes Maxim Levitsky
2010-11-29 2:09 ` [PATCH 1/5] firewire: ohci: restore GUID on resume Maxim Levitsky
2010-11-29 2:09 ` [PATCH 2/5] firewire: ohci: restart ISO DMA contexts on resume from low power mode Maxim Levitsky
2010-11-29 2:09 ` [PATCH 3/5] NET: IPV4: ARP: allow to invalidate specific ARP entries Maxim Levitsky
2010-12-04 23:15 ` Maxim Levitsky
2010-12-05 8:19 ` Eric Dumazet
2010-12-05 11:23 ` [PATCH] net: RCU conversion of dev_getbyhwaddr() and arp_ioctl() Eric Dumazet
2010-12-05 12:03 ` [PATCH net-2.6] llc: fix a device refcount imbalance Eric Dumazet
2010-12-08 17:59 ` David Miller [this message]
2010-12-09 3:46 ` Maxim Levitsky
2010-12-16 21:49 ` Maxim Levitsky
2010-12-08 18:05 ` [PATCH] net: RCU conversion of dev_getbyhwaddr() and arp_ioctl() David Miller
2010-12-08 18:07 ` Eric Dumazet
2010-12-08 18:10 ` David Miller
2010-12-08 18:11 ` Eric Dumazet
2011-01-07 12:47 ` [PATCH 3/5] NET: IPV4: ARP: allow to invalidate specific ARP entries Maxim Levitsky
2011-01-07 12:57 ` Eric Dumazet
2011-01-07 13:15 ` Maxim Levitsky
2011-01-08 23:57 ` Maxim Levitsky
2011-01-11 0:11 ` David Miller
2010-11-29 2:09 ` [PATCH 4/5] firewire: net: invalidate ARP entries of removed nodes Maxim Levitsky
2010-11-29 2:09 ` [PATCH 5/5] firewire: net: ratelimit error messages Maxim Levitsky
2010-11-29 15:02 ` [PATCH 0/5 V2] Firewire networking assorted fixes Stefan Richter
2010-12-04 23:14 ` Maxim Levitsky
2010-12-08 3:32 ` Maxim Levitsky
2010-12-09 1:42 ` Maxim Levitsky
[not found] ` <20101208040559.20639.qmail@stuge.se>
[not found] ` <1291809485.5421.0.camel@maxim-laptop>
2010-12-12 17:09 ` [PATCH update] firewire: net: add carrier detection Stefan Richter
2010-12-12 23:05 ` Ben Hutchings
2010-12-13 0:46 ` [PATCH update 2] " Stefan Richter
2010-12-13 23:01 ` [PATCH update 3] " Stefan Richter
2010-12-14 23:46 ` Maxim Levitsky
2010-12-16 1:17 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101208.095920.229730656.davem@davemloft.net \
--to=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux1394-devel@lists$(echo .)sourceforge.net \
--cc=maximlevitsky@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=opurdila@ixiacom$(echo .)com \
--cc=stable@kernel$(echo .)org \
--cc=stefanr@s5r6$(echo .)in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox