From: Octavian Purdila <opurdila@ixiacom•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Stephen Hemminger <shemminger@vyatta•com>,
netdev@vger•kernel.org,
"Lucian Adrian Grijincu" <lucian.grijincu@gmail•com>,
Vlad Dogaru <ddvlad@rosedu•org>
Subject: Re: [PATCH] iproute2: ip: add wilcard support for device matching
Date: Fri, 10 Dec 2010 19:32:59 +0200 [thread overview]
Message-ID: <201012101932.59352.opurdila@ixiacom.com> (raw)
In-Reply-To: <1291998740.3580.162.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail•com>
Date: Friday 10 December 2010, 18:32:20
> Le vendredi 10 décembre 2010 à 08:18 -0800, Stephen Hemminger a écrit :
> > On Fri, 10 Dec 2010 16:58:12 +0200
> >
> > Octavian Purdila <opurdila@ixiacom•com> wrote:
> > > Allow the users to specify a wildcard when selecting a device:
> > >
> > > $ ip set link dev dummy* up
> > >
> > > We do this by expanding the original command line in multiple lines
> > > which we then feed via a pipe to a forked ip processed run in batch
> > > mode.
> >
> > Seems like feature creep. Can't you do this with bash completion
> > script instead.
This feature would make my life easier so to me its just a nice feature :)
Sure I can do it as a bash completion script but:
- bash does not run everywhere
- having it in iproute would make it available to everyone
- its userspace so the price to pay for a few more lines of code for usability
seems reasonable
- I don't know how scalable you can make the bash completion script
> furthermore, "*" is allowed in a device name
>
> ip link add link bond0 "vlan*" txqueuelen 100 type vlan id 999
>
Would allowing escaping it fix the issue? Like:
ip link add link bond0 "vlan\*" txqueuelen 100 type vlan id 999
next prev parent reply other threads:[~2010-12-10 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 14:58 [PATCH] iproute2: ip: add wilcard support for device matching Octavian Purdila
2010-12-10 16:18 ` Stephen Hemminger
2010-12-10 16:32 ` Eric Dumazet
2010-12-10 17:32 ` Octavian Purdila [this message]
2010-12-10 17:42 ` Eric Dumazet
2010-12-10 18:06 ` Octavian Purdila
2010-12-17 13:38 ` jamal
2010-12-19 9:32 ` Vlad Dogaru
2010-12-21 13:14 ` jamal
2011-01-08 21:10 ` Philip Prindeville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012101932.59352.opurdila@ixiacom.com \
--to=opurdila@ixiacom$(echo .)com \
--cc=ddvlad@rosedu$(echo .)org \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=lucian.grijincu@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox