Subject: Re: [patch] isdn: return -EFAULT if copy_from_user() fails

From: Nicolas Kaiser <[email-masked]>
Date: Sat, 11 Dec 2010 01:41:54 +0100

Ahem, we're printing this return value:

* Dan Carpenter <[email-masked]>:
> -	if ((ret = copy_from_user(&size, p, sizeof(int)))) {
             ^^^
> +	if (copy_from_user(&size, p, sizeof(int))) {
>  		printk(KERN_ERR"isar_load_firmware copy_from_user ret %d\n", ret);
                                                                             ^^^
> -		return ret;
> +		return -EFAULT;

Cheers,
Nicolas Kaiser