From: Jarek Poplawski <jarkao2@gmail•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>,
Changli Gao <xiaosuo@gmail•com>, netdev <netdev@vger•kernel.org>,
Patrick McHardy <kaber@trash•net>
Subject: Re: [PATCH net-next-2.6] net: force a fresh timestamp for ingress packets
Date: Fri, 17 Dec 2010 08:34:13 +0000 [thread overview]
Message-ID: <20101217083413.GB6907@ff.dom.local> (raw)
In-Reply-To: <1292573297.2655.42.camel@edumazet-laptop>
On Fri, Dec 17, 2010 at 09:08:17AM +0100, Eric Dumazet wrote:
> Le vendredi 17 décembre 2010 ?? 07:30 +0000, Jarek Poplawski a écrit :
>
> > It is wrong because it brings back the inconsistency with ping etc.
> > described by Alex Sidorenko in the changelog of netem patch, but
> > use normal (not netem) ingress scheduling (ping results shouldn't
> > depend on sniffers).
>
> Care to explain why only netem should take care of this delaying
> problem ?
> If a packet is delayed on other qdisc, dont we have the same problem ?
netem was treated as a special case just to pretend (lie) about the
net outside (still not depending on sniffers), but it's hard to
believe there are "normal" ping users after netem.
>
> Right now, ping lies, giving different results if a sniffer is active or
> not.
>
> Care to suggest an alternative patch, because I am lost at this point ?
Just what I wrote earlier: consider one additional cloning in
dev_queue_xmit_nit or maybe resetting the timestamp with act_skbedit?
Thanks,
Jarek P.
next prev parent reply other threads:[~2010-12-17 8:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 15:50 [PATCH net-next-2.6] net: force a fresh timestamp for ingress packets Eric Dumazet
2010-12-16 21:17 ` Jarek Poplawski
2010-12-16 21:30 ` Eric Dumazet
2010-12-16 22:08 ` Jarek Poplawski
2010-12-16 22:26 ` Eric Dumazet
2010-12-16 22:42 ` Jarek Poplawski
2010-12-16 23:31 ` Eric Dumazet
2010-12-17 7:30 ` Jarek Poplawski
2010-12-17 8:08 ` Eric Dumazet
2010-12-17 8:34 ` Jarek Poplawski [this message]
2010-12-17 8:59 ` Jarek Poplawski
2010-12-17 9:26 ` Eric Dumazet
2010-12-21 7:22 ` [PATCH net-next-2.6] net: timestamp cloned packet in dev_queue_xmit_nit Eric Dumazet
2010-12-21 7:56 ` Changli Gao
2010-12-21 18:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217083413.GB6907@ff.dom.local \
--to=jarkao2@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiaosuo@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox