Subject: Re: [net-next-2.6 PATCH v2] net: implement mechanism for HW based QOS

From: Stephen Hemminger <[email-masked]>
Date: Mon, 20 Dec 2010 14:58:44 -0800

On Mon, 20 Dec 2010 22:48:07 +0000
Ben Hutchings <[email-masked]> wrote:

> > +	u8 num_tc;
> > +	struct netdev_tc_txq tc_to_txq[16];
> > +	u8 prio_tc_map[16];  
> 
> That seems like a fair amount of data to add to every net device,
> considering that users may create e.g. a lot of VLAN devices and they
> won't use this state at all.  Have you considered putting these in a
> structure that is accessed indirectly?

The tc stuff should use indirection and only allocate if needed.

--