Subject: Re: [PATCH 1/1] netfilter: ebtables: make broute table work again

From: Florian Westphal <[email-masked]>
Date: Fri, 24 Dec 2010 01:55:50 +0100

Changli Gao <[email-masked]> wrote:
> > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
> > index 6f6d8e1..1d677bf 100644
> > --- a/net/bridge/br_input.c
> > +++ b/net/bridge/br_input.c
> > @@ -178,7 +178,7 @@ forward:
> >        case BR_STATE_FORWARDING:
> >                rhook = rcu_dereference(br_should_route_hook);
> >                if (rhook) {
> > -                       if ((*rhook)(skb))
> > +                       if (rhook(skb))
> 
> I don't think this change is necessary. Would you like to remove this
> change and test again?

Its not needed, but i consider it less confusing.
I do not have a strong preference, though.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html