From: Baruch Siach <baruch@tkos•co.il>
To: Shawn Guo <shawn.guo@freescale•com>
Cc: davem@davemloft•net, gerg@snapgear•com, eric@eukrea•com,
bryan.wu@canonical•com, r64343@freescale•com,
B32542@freescale•com, u.kleine-koenig@pengutronix•de,
lw@karo-electronics•de, w.sang@pengutronix•de,
s.hauer@pengutronix•de, linux-arm-kernel@lists•infradead.org,
netdev@vger•kernel.org
Subject: Re: [PATCH 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac
Date: Thu, 30 Dec 2010 07:29:25 +0200 [thread overview]
Message-ID: <20101230052925.GA11160@jasper.tkos.co.il> (raw)
In-Reply-To: <20101230042858.GA20651@freescale.com>
Hi Shawn,
On Thu, Dec 30, 2010 at 12:29:00PM +0800, Shawn Guo wrote:
> On Wed, Dec 29, 2010 at 06:05:20PM +0800, Shawn Guo wrote:
> > On Wed, Dec 29, 2010 at 08:53:30AM +0200, Baruch Siach wrote:
> > > Please add netdev@vger•kernel.org to the Cc of all your fec driver
> > > patches.
> > >
> > > On Tue, Dec 28, 2010 at 10:55:48PM +0800, Shawn Guo wrote:
> > > > Add mac field into fec_platform_data and consolidate function
> > > > fec_get_mac to get mac address in following order.
> > > >
> > > > 1) kernel command line fec_mac=xx:xx:xx...
> > >
> > > In the case of dual MAC that you later add support for, the address which one
> > > is being set? Is there a way to set both in kernel command line?
> > >
> > The fec0 gets fec_mac and fec1 gets fec_mac + 1. The following code
> > in function fec_get_mac takes care of it.
> >
> > /* Adjust MAC if using default MAC address */
> > if (iap == fec_mac_default)
> > dev->dev_addr[ETH_ALEN-1] = fec_mac_default[ETH_ALEN-1] + fep->pdev->id;
> > > Also, instead of inventing another kernel command line parameter, it is
> > > better IMO to use the module parameters mechanism. The greth NIC driver
> > > already uses this method for setting MAC address. Look for 'macaddr' in
> > > drivers/net/greth.c, and the explanation at the beginning of
> > > Documentation/kernel-parameters.txt.
> > >
> > Sounds good. Thanks.
> >
> I just thought this over again. Module parameter might not be
> the best here. fec is usually used to mount nfs during boot,
> which requires a built-in driver other than module.
See the explanation at the beginning of Documentation/kernel-parameters.txt.
You can give module parameters at the kernel command line.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos•co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2010-12-30 5:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1293548155-16328-1-git-send-email-shawn.guo@freescale.com>
[not found] ` <1293548155-16328-4-git-send-email-shawn.guo@freescale.com>
[not found] ` <20101229065329.GB31010@jasper.tkos.co.il>
[not found] ` <20101229103014.GD19347@freescale.com>
2010-12-29 10:37 ` [PATCH 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac Uwe Kleine-König
2010-12-29 11:08 ` Shawn Guo
2010-12-29 11:10 ` Uwe Kleine-König
2010-12-29 12:00 ` Shawn Guo
[not found] ` <20101229100520.GB19347@freescale.com>
[not found] ` <20101229103138.GT14221@pengutronix.de>
2010-12-29 11:58 ` Shawn Guo
2010-12-29 12:42 ` Uwe Kleine-König
2010-12-30 2:12 ` Shawn Guo
2010-12-30 8:04 ` Uwe Kleine-König
2010-12-30 4:29 ` Shawn Guo
2010-12-30 5:29 ` Baruch Siach [this message]
2010-12-30 7:20 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101230052925.GA11160@jasper.tkos.co.il \
--to=baruch@tkos$(echo .)co.il \
--cc=B32542@freescale$(echo .)com \
--cc=bryan.wu@canonical$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric@eukrea$(echo .)com \
--cc=gerg@snapgear$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=lw@karo-electronics$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=r64343@freescale$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawn.guo@freescale$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=w.sang@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox