From: Rusty Russell <rusty@rustcorp•com.au>
To: Michal Hocko <mhocko@suse•cz>
Cc: "Michael S. Tsirkin" <mst@redhat•com>,
virtualization@lists•linux-foundation.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH] virtio: use __GFP_NOWARN for try_fill_recv in virtnet_poll
Date: Tue, 15 Feb 2011 21:39:03 +1030 [thread overview]
Message-ID: <201102152139.03451.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20110215102549.GD8341@tiehlicka.suse.cz>
On Tue, 15 Feb 2011 08:55:50 pm Michal Hocko wrote:
> On Tue 15-02-11 20:41:29, Rusty Russell wrote:
> > On Tue, 15 Feb 2011 08:05:27 pm Michal Hocko wrote:
> > > Hi,
> > > we have started seeing a lot of allocator messages complaining about
> > > failed allocations from virtnet_poll in soft IRQ. Could you consider the
> > > following patch, please?
> >
> > Do we really want to silence this? Isn't warning about it kind of the
> > point? Your network is probably sucking if this happens...
>
> What can user do about it? Is the low level memory allocator message
> very much usefull for him? Maybe we can add a printk_once in the fail
> path with some more useful and virtio specific message.
That's an argument against ever printing any message.
What we need to know is why does this happen with virtio_net and not other
cards? If it happens to them too, and they silently fall back, all good.
I want to make sure we're not papering over a real problem...
Thanks,
Rusty.
next prev parent reply other threads:[~2011-02-15 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 9:35 [PATCH] virtio: use __GFP_NOWARN for try_fill_recv in virtnet_poll Michal Hocko
2011-02-15 10:11 ` Rusty Russell
2011-02-15 10:25 ` Michal Hocko
2011-02-15 11:09 ` Rusty Russell [this message]
2011-02-15 12:42 ` Michal Hocko
2011-02-15 12:39 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102152139.03451.rusty@rustcorp.com.au \
--to=rusty@rustcorp$(echo .)com.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mhocko@suse$(echo .)cz \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox