From: "Vlad Zolotarov" <vladz@broadcom•com>
To: "Tom Herbert" <therbert@google•com>
Cc: "Ben Hutchings" <bhutchings@solarflare•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"Eilon Greenstein" <eilong@broadcom•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH] bnx2x: Support for managing RX indirection table
Date: Wed, 16 Feb 2011 07:53:38 +0200 [thread overview]
Message-ID: <201102160753.38598.vladz@broadcom.com> (raw)
In-Reply-To: <AANLkTi=VT7BMpJZeE_gKOceNw+=Db40p3znmyt=Jc2Un@mail.gmail.com>
On Wednesday 16 February 2011 00:50:18 Tom Herbert wrote:
> >> + u32 rx_indir_table[128];
> >
> > Shouldn't the dimension be TSTORM_INDIRECTION_TABLE_SIZE?
> >
>
> It's not a defined constant, so the alternative would be to malloc it
> which seems like overkill to me.
>
> Broadcom guys: are there any adapters or configuration of bnx2x where
> the indirection table would be greater than 128?
Although for all currently supported adapters the actual value of the indirection
table size is 128 I agree with Ben and would like to ask u to use the above macro (which
is a rename for an entry in a per-adapter array of constants) to keep the code
scalable and clean. I don't think that a malloc would be too much of a price for it... ;)
thanks,
vlad
>
> Tom
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2011-02-16 5:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 16:24 [PATCH] bnx2x: Support for managing RX indirection table Tom Herbert
2011-02-15 16:35 ` Eric Dumazet
2011-02-15 16:48 ` Ben Hutchings
2011-02-15 22:50 ` Tom Herbert
2011-02-16 5:53 ` Vlad Zolotarov [this message]
2011-02-15 17:31 ` Vlad Zolotarov
2011-02-15 17:39 ` Vlad Zolotarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102160753.38598.vladz@broadcom.com \
--to=vladz@broadcom$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eilong@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=therbert@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox