Subject: Re: [PATCH] bonding/vlan: Avoid mangled NAs on slaves without VLAN tag insertion

From: Greg KH <[email-masked]>
Date: Wed, 16 Feb 2011 13:58:55 -0800

On Mon, Feb 07, 2011 at 01:17:54PM -0800, David Miller wrote:
> From: Ben Hutchings <[email-masked]>
> Date: Mon, 07 Feb 2011 19:20:55 +0000
> 
> > This is related to commit f88a4a9b65a6f3422b81be995535d0e69df11bb8
> > upstream, but the bug cannot be properly fixed without the other
> > changes to VLAN tagging in 2.6.37.
> > 
> > bond_na_send() attempts to insert a VLAN tag in between building and
> > sending packets of the respective formats.  If the slave does not
> > implement hardware VLAN tag insertion then vlan_put_tag() will mangle
> > the network-layer header because the Ethernet header is not present at
> > this point (unlike in bond_arp_send()).
> > 
> > Signed-off-by: Ben Hutchings <[email-masked]>
> 
> Acked-by: David S. Miller <[email-masked]>

Great, thanks for the patch, now queued up for the next .32-stable
release.

greg k-h