From: "Matt Carlson" <mcarlson@broadcom•com>
To: "Greg KH" <greg@kroah•com>
Cc: "Matthew Carlson" <mcarlson@broadcom•com>,
"David Miller" <davem@davemloft•net>,
"stable@kernel•org" <stable@kernel•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [stable] [PATCH net-2.6/stable] tg3: Restrict phy ioctl access
Date: Wed, 16 Feb 2011 16:11:45 -0800 [thread overview]
Message-ID: <20110217001145.GA11165@mcarlson.broadcom.com> (raw)
In-Reply-To: <20110217000035.GB6296@kroah.com>
On Wed, Feb 16, 2011 at 04:00:35PM -0800, Greg KH wrote:
> On Wed, Feb 16, 2011 at 03:52:48PM -0800, Matt Carlson wrote:
> > On Wed, Feb 16, 2011 at 03:11:03PM -0800, David Miller wrote:
> > > From: "Matt Carlson" <mcarlson@broadcom•com>
> > > Date: Wed, 16 Feb 2011 15:06:13 -0800
> > >
> > > > On Wed, Feb 16, 2011 at 02:39:35PM -0800, Greg KH wrote:
> > > >> On Tue, Feb 15, 2011 at 02:51:10PM -0800, Matt Carlson wrote:
> > > >> > If management firmware is present and the device is down, the firmware
> > > >> > will assume control of the phy. If a phy access were allowed from the
> > > >> > host, it will collide with firmware phy accesses, resulting in
> > > >> > unpredictable behavior. This patch fixes the problem by disallowing phy
> > > >> > accesses during the problematic condition.
> > > >> >
> > > >> > Upstream commit ID f746a3136a61ae535c5d0b49a9418fa21edc61b5
> > > >>
> > > >> There is no such upstream git commit id in Linus's tree. What am I
> > > >> doing wrong here?
> > > >
> > > > The commit is in Dave Miller's net-next-2.6 tree.
> > > >
> > >
> > > If it wasn't appropriate for net-2.6, it absolutely it not appropriate
> > > for -stable.
> >
> > net-2.6 was the target tree for the patch. The stable_kernel_rules.txt
> > seemed to suggest that I could just CC stable@kernel•org with the
> > commit ID, and Greg would pull it in as the process dictates. If that
> > isn't correct, what is the preferred way to expedite the integration of
> > a patch?
>
> Keep reading that file, it says to put the Cc: in the signed-off-by area
> of the original patch.
Ah. Yes. I see that now.
> Also, that file says the patch has to be in Linus's tree, otherwise
> sending me a git commit id of some other tree isn't going to help at
> all.
I see. Thanks for the tips.
next prev parent reply other threads:[~2011-02-17 0:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 22:51 [PATCH net-2.6/stable] tg3: Restrict phy ioctl access Matt Carlson
2011-02-16 22:39 ` [stable] " Greg KH
2011-02-16 23:06 ` Matt Carlson
2011-02-16 23:11 ` David Miller
2011-02-16 23:52 ` Matt Carlson
2011-02-17 0:00 ` Greg KH
2011-02-17 0:11 ` Matt Carlson [this message]
2011-02-17 0:10 ` David Miller
2011-02-17 0:39 ` Matt Carlson
2011-02-17 0:56 ` David Miller
2011-02-17 22:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217001145.GA11165@mcarlson.broadcom.com \
--to=mcarlson@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=greg@kroah$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox