Subject: Re: [PATCH] skge: don't mark carrier down at start

From: Andrew Morton <[email-masked]>
Date: Wed, 23 Feb 2011 16:52:43 -0800

On Wed, 23 Feb 2011 16:44:49 -0800
Stephen Hemminger <[email-masked]> wrote:

> The API for network devices has changed so that setting carrier
> off at probe is no longer required. This should fix the IPv6 addrconf
> issue.
> 
> Signed-off-by: Stephen Hemminger <[email-masked]>
> 
> 
> --- a/drivers/net/skge.c	2011-02-23 16:40:36.351045685 -0800
> +++ b/drivers/net/skge.c	2011-02-23 16:40:48.315136410 -0800
> @@ -3856,9 +3856,6 @@ static struct net_device *skge_devinit(s
>  	memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port*8, ETH_ALEN);
>  	memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
>  
> -	/* device is off until link detection */
> -	netif_carrier_off(dev);
> -
>  	return dev;
>  }

Thanks, but please don't forget to acknowledge the bug reporter's
efforts.

Also, quoting the bugzilla URL in the changelog helps when people come
along to close off open bug reports.

From: Stephen Hemminger <[email-masked]>

The API for network devices has changed so that setting carrier off at
probe is no longer required.  This should fix the IPv6 addrconf issue.

Addresses https://bugzilla.kernel.org/show_bug.cgi?id=29612

Signed-off-by: Stephen Hemminger <[email-masked]>
Reported-by: George Billios <[email-masked]>
Cc: David Miller <[email-masked]>
Signed-off-by: Andrew Morton <[email-masked]>
---

 drivers/net/skge.c |    3 ---
 1 file changed, 3 deletions(-)

diff -puN drivers/net/skge.c~skge-dont-mark-carrier-down-at-start drivers/net/skge.c
--- a/drivers/net/skge.c~skge-dont-mark-carrier-down-at-start
+++ a/drivers/net/skge.c
@@ -3856,9 +3856,6 @@ static struct net_device *skge_devinit(s
 	memcpy_fromio(dev->dev_addr, hw->regs + B2_MAC_1 + port*8, ETH_ALEN);
 	memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);
 
-	/* device is off until link detection */
-	netif_carrier_off(dev);
-
 	return dev;
 }
 
_