From: Florian Fainelli <florian@openwrt•org>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH 1/2 net-next-2.6] r6040: fix multicast operations
Date: Wed, 23 Feb 2011 23:32:40 +0100 [thread overview]
Message-ID: <201102232332.40712.florian@openwrt.org> (raw)
In-Reply-To: <20110223.142254.59671988.davem@davemloft.net>
Hello David,
On Wednesday 23 February 2011 23:22:54 David Miller wrote:
> From: Florian Fainelli <florian@openwrt•org>
> Date: Wed, 23 Feb 2011 15:32:34 +0100
>
> > From: Shawn Lin <shawn@dmp•com.tw>
> >
> > The original code does not work well when the number of mulitcast
> > address to handle is greater than MCAST_MAX. It only enable promiscous
> > mode instead of multicast hash table mode, so the hash table function
> > will not be activated and all multicast frames will be recieved in this
> > condition.
> >
> > This patch fixes the following issues with the r6040 NIC operating in
> > multicast:
> >
> > 1) When the IFF_ALLMULTI flag is set, we should write 0xffff to the NIC
> > hash table registers to make it process multicast traffic.
> >
> > 2) When the number of multicast address to handle is smaller than
> > MCAST_MAX, we should use the NIC multicast registers MID1_{L,M,H}.
> >
> > 3) The hashing of the address was not correct, due to an invalid
> > substraction (15 - (crc & 0x0f)) instead of (crc & 0x0f) and an
> > incorrect crc algorithm (ether_crc_le) instead of (ether_crc).
> >
> > 4) If necessary, we should set HASH_EN flag in MCR0 to enable multicast
> > hash table function.
> >
> > CC: stable@kernel•org
>
> If it's not appropriate for net-2.6, it's not appropriate for -stable
> either.
>
> I'm applying this to net-next-2.6, as you requested, and removing the
> stable CC: tag from the commit message.
It is appropriate for kernel versions including e1d44477 (net: convert
multiple drivers to use netdev_for_each_mc_addr). The patch was generated from
a net-next-2.6 tree, thus the mention in the subject, which was certainly
misleading, sorry about that.
I will submit a patch for the "older" stable kernel releases prior to that
commit.
--
Florian
next prev parent reply other threads:[~2011-02-23 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 14:32 [PATCH 1/2 net-next-2.6] r6040: fix multicast operations Florian Fainelli
2011-02-23 22:22 ` David Miller
2011-02-23 22:32 ` Florian Fainelli [this message]
2011-02-23 22:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102232332.40712.florian@openwrt.org \
--to=florian@openwrt$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox