Subject: Re: LRO disable warnings on kernel 2.6.38

From: Stephen Hemminger <[email-masked]>
Date: Fri, 18 Mar 2011 08:15:24 -0700

On Fri, 18 Mar 2011 15:33:04 +0100
Eric Dumazet <[email-masked]> wrote:

> Le vendredi 18 mars 2011 à 14:17 +0000, Ben Hutchings a écrit :
> 
> > WARN is correct as this is a driver bug.  But I agree that the
> > device/driver ID should be included.
> 
> stack trace gives absolutely no useful indication here.
> 
> Bug is in driver, yet we dump information on core network stack ?
> 
> pr_err() is an error indication, not a warning by the way ;)

The advantage of WARN is that it doesn't get ignored and shows
up in kernel oops. But agreed it should print out as much device
info as possible to finger the broken device driver.