Subject: Re: [RFC] myri10ge: small rx_done refactoring

From: Stephen Hemminger <[email-masked]>
Date: Wed, 23 Mar 2011 08:33:57 -0700

On Wed, 23 Mar 2011 13:52:04 +0100
Stanislaw Gruszka <[email-masked]> wrote:

> Add lro_enable variable to read NETIF_F_LRO flag only once per napi poll
> call. This should fix theoretical race condition with
> myri10ge_set_rx_csum() and myri10ge_set_flags() where flag NETIF_F_LRO
> can be changed.

You may need a barrier or the race may still be there.
The driver seems to use mb() where wmb() is intended, and never use rmb()?

--