From: Greg KH <greg@kroah•com>
To: David Miller <davem@davemloft•net>
Cc: shemminger@vyatta•com, serge.hallyn@ubuntu•com,
bhutchings@solarflare•com, eparis@redhat•com,
eparis@parisplace•org, segoon@openwall•com,
linux-kernel@vger•kernel.org, mjt@tls•msk.ru, arnd@arndb•de,
mirqus@gmail•com, netdev@vger•kernel.org, kuznet@ms2•inr.ac.ru,
pekkas@netcore•fi, jmorris@namei•org, yoshfuji@linux-ipv6•org,
kaber@trash•net, eric.dumazet@gmail•com, therbert@google•com,
xiaosuo@gmail•com, jesse@nicira•com, kees.cook@canonical•com,
eugene@redhat•com, dan.j.rosenberg@gmail•com,
akpm@linux-foundation•org, sds@tycho•nsa.gov,
linux-security-module@vger•kernel.org, dwalsh@redhat•com,
dhowells@redhat•com
Subject: Re: [PATCH v2] net: don't allow CAP_NET_ADMIN to load non-netdev kernel modules
Date: Thu, 24 Mar 2011 14:57:54 -0700 [thread overview]
Message-ID: <20110324215754.GA12023@kroah.com> (raw)
In-Reply-To: <20110324.144628.58411809.davem@davemloft.net>
On Thu, Mar 24, 2011 at 02:46:28PM -0700, David Miller wrote:
> From: Stephen Hemminger <shemminger@vyatta•com>
> Date: Thu, 24 Mar 2011 14:39:44 -0700
>
> > This breaks for many of the tunneling protocols, that rely on
> > autoload for names like "sit0"
>
> Frankly I'm very disappointed in the fallout this has been causing.
>
> Everyone supporting this change, get real, and admit it doing in fact
> cause a serious regression.
>
> If you can't get past that simple fact, you cannot discuss this issue
> intelligently.
>
> You can't say "userland will fix things up"
>
> Because we're never supposed to break userland in the first place.
>
> There is simply no excuse for this and I want this change reverted
> both in Linus's tree and in -stable.
Ok, as I totally got lost in the thread here, what is the git commit id
of the patch to revert?
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-24 21:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 15:12 module loading with CAP_NET_ADMIN Vasiliy Kulikov
2011-02-24 16:34 ` Ben Hutchings
2011-02-25 12:30 ` Vasiliy Kulikov
2011-02-25 15:14 ` [PATCH] don't allow CAP_NET_ADMIN to load non-netdev kernel modules Vasiliy Kulikov
2011-02-25 17:25 ` Valdis.Kletnieks
2011-02-25 17:47 ` Vasiliy Kulikov
2011-02-25 17:48 ` Ben Hutchings
2011-02-25 18:47 ` David Miller
2011-02-25 19:02 ` Vasiliy Kulikov
2011-02-25 19:05 ` David Miller
2011-02-25 19:07 ` Ben Hutchings
2011-02-25 19:16 ` David Miller
2011-02-25 19:30 ` Ben Hutchings
2011-02-25 19:43 ` David Miller
2011-02-25 19:53 ` Ben Hutchings
2011-02-25 20:37 ` David Miller
2011-02-25 20:38 ` Ben Hutchings
2011-02-25 20:59 ` Michał Mirosław
2011-02-27 20:22 ` Arnd Bergmann
2011-02-28 9:29 ` Michael Tokarev
2011-02-28 9:51 ` Vasiliy Kulikov
2011-02-28 19:23 ` David Miller
2011-03-01 19:48 ` [PATCH] net: " Vasiliy Kulikov
2011-03-01 20:13 ` Ben Hutchings
2011-03-01 21:33 ` [PATCH v2] " Vasiliy Kulikov
2011-03-02 7:15 ` Michael Tokarev
2011-03-09 22:06 ` Vasiliy Kulikov
2011-03-09 22:09 ` David Miller
2011-03-09 22:53 ` James Morris
2011-03-10 9:49 ` Vasiliy Kulikov
2011-03-02 16:01 ` Kees Cook
2011-03-02 19:39 ` Jake Edge
2011-03-02 19:43 ` Vasiliy Kulikov
2011-03-02 19:49 ` Jake Edge
2011-03-02 20:18 ` Vasiliy Kulikov
2011-03-02 20:38 ` Jake Edge
2011-03-02 20:40 ` Jake Edge
2011-03-22 20:47 ` Eric Paris
2011-03-24 15:37 ` Serge E. Hallyn
2011-03-24 18:03 ` Eric Paris
2011-03-24 18:33 ` Ben Hutchings
2011-03-24 20:26 ` Serge E. Hallyn
2011-03-24 21:39 ` Stephen Hemminger
2011-03-24 21:46 ` David Miller
2011-03-24 21:57 ` Serge E. Hallyn
2011-03-24 22:15 ` Eric Paris
2011-03-24 21:57 ` Greg KH [this message]
2011-03-26 10:35 ` Vasiliy Kulikov
2011-02-27 11:44 ` [PATCH] " Vasiliy Kulikov
2011-02-27 23:18 ` David Miller
2011-02-27 23:19 ` David Miller
2011-02-25 15:29 ` module loading with CAP_NET_ADMIN Michael Tokarev
2011-02-25 15:57 ` Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324215754.GA12023@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bhutchings@solarflare$(echo .)com \
--cc=dan.j.rosenberg@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=dwalsh@redhat$(echo .)com \
--cc=eparis@parisplace$(echo .)org \
--cc=eparis@redhat$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=eugene@redhat$(echo .)com \
--cc=jesse@nicira$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kees.cook@canonical$(echo .)com \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=mirqus@gmail$(echo .)com \
--cc=mjt@tls$(echo .)msk.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pekkas@netcore$(echo .)fi \
--cc=sds@tycho$(echo .)nsa.gov \
--cc=segoon@openwall$(echo .)com \
--cc=serge.hallyn@ubuntu$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
--cc=therbert@google$(echo .)com \
--cc=xiaosuo@gmail$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox