From: Arnd Bergmann <arnd@arndb•de>
To: David Miller <davem@davemloft•net>
Cc: davej@redhat•com, netdev@vger•kernel.org
Subject: Re: appletalk oops.
Date: Fri, 1 Apr 2011 16:26:22 +0200 [thread overview]
Message-ID: <201104011626.22656.arnd@arndb.de> (raw)
In-Reply-To: <20110331.185823.232755679.davem@davemloft.net>
On Friday 01 April 2011, David Miller wrote:
> appletalk: Fix OOPS in atalk_release().
>
> Commit 60d9f461a20ba59219fdcdc30cbf8e3a4ad3f625 ("appletalk: remove
> the BKL") added a dereference of "sk" before checking for NULL in
> atalk_release().
>
> Guard the code block completely, rather than partially, with the
> NULL check.
>
> Reported-by: Dave Jones <davej@redhat•com>
> Signed-off-by: David S. Miller <davem@davemloft•net>
Oops indeed.
The best excuse I have is that nobody who has access to a real
appletalk network stepped up to test it when I submitted the patches
and that I first suggested deleting the protocol instead because
I had no idea if my patch made any sense.
Acked-by: Arnd Bergmann <arnd@arndb•de>
prev parent reply other threads:[~2011-04-01 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 20:05 appletalk oops Dave Jones
2011-04-01 1:58 ` David Miller
2011-04-01 14:26 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104011626.22656.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=davej@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox