Subject: Re: [PATCH 4/8] s2io: convert to set_phys_id

From: Stephen Hemminger <[email-masked]>
Date: Mon, 4 Apr 2011 18:08:24 -0700

last_gpio_ctrl_val = readq(&bar0->gpio_control);
> [...]
> 
> I think last_gpio_ctrl_val needs to be moved to struct s2io_nic and
> initialised only in the ETHTOOL_ID_ACTIVE case.

Strange there is a value already there and unused?
   sp->adapt_ctrl_org