Subject: Re: Kernel panic when using bridge

From: Bandan Das <[email-masked]>
Date: Tue, 12 Apr 2011 12:45:57 -0400

On  0, Eric Dumazet <[email-masked]> wrote:
> Le mardi 12 avril 2011 à 09:20 -0700, Stephen Hemminger a écrit :
> 
> > I think the confusion is that IPCB(skb) is not the IP header but
> > scratch space used during IP header processing. Before the sanitize
> > patch the CB was cleared.
> > 
> > Acked-by: Stephen Hemminger <[email-masked]>
> 
> Should we clear it also in br_nf_dev_queue_xmit(), since we did this
> prior to commit 462fb2af9788a8 ?
> 
> Thanks !
> 
Wouldn't that clear out any valid IP options if it were there ? I think
that was the whole point of adding br_parse_ip_options :

/* BUG: Should really parse the IP options here. */
memset(IPCB(skb), 0, sizeof(struct inet_skb_parm));

-- 
Bandan