Subject: Re: [patch net-next-2.6] net: call dev_alloc_name from register_netdevice

From: Stephen Hemminger <[email-masked]>
Date: Sat, 30 Apr 2011 10:34:44 -0700

On Sat, 30 Apr 2011 13:21:32 +0200
Jiri Pirko <[email-masked]> wrote:

> Force dev_alloc_name() to be called from register_netdevice() by
> dev_get_valid_name(). That allows to remove multiple explicit
> dev_alloc_name() calls.
> 
> The possibility to call dev_alloc_name in advance remains.
> 
> This also fixes veth creation regresion caused by
> 84c49d8c3e4abefb0a41a77b25aa37ebe8d6b743
> 
> Signed-off-by: Jiri Pirko <[email-masked]>

The problem with this then you have to audit all the calls
to register_netdevice to make sure that user can't provide a bad
value which then is passed a format string. Why not just fix
just veth which would be safer.