From: "L. Alberto Giménez" <agimenez@sysvalve•es>
To: David Miller <davem@davemloft•net>
Cc: linux-kernel@vger•kernel.org, dgiagio@gmail•com,
dborca@yahoo•com, pmcenery@gmail•com, david.hill@ubisoft•com,
linux-usb@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH] ipheth.c: Enable IP header alignment
Date: Mon, 2 May 2011 23:12:45 +0200 [thread overview]
Message-ID: <20110502211245.GA18334@bart.evergreen.loc> (raw)
In-Reply-To: <20110502.124622.226785624.davem@davemloft.net>
On Mon, May 02, 2011 at 12:46:22PM -0700, David Miller wrote:
>
> Why did this break things?
Hi, I don't know. As upstream is unresponsive and is applying patches to his
private repo without submitting them to the list (which I can understand), I
decided to submit the particular fix so mainline users can get tethering working
again.
I received a forwarded email with the patch (I think that's because I submitted
the driver to mainline) asking for the mainline driver status and if it was
being maintained.
>
> I'm not applying a fix when nobody can explain the reason why:
>
> 1) Things broke in the first place
> 2) Forcing reservation of 2 bytes fixes things
Honestly, I can't answer either of those ones. I just submitted a patch that
*seemed* to fix the problem (I don't own an iPhone device since long time ago),
after explictly requesting upstream to submit by himself, and getting a
negative.
> Where is the built in assumption about "2" and why does it exist? Why
> can't we fix this code not to have such assumptions in the first
> place?
Ditto.
At this point, I think that David, Diego or Daniel should step in if they want
to keep on with this discussion. I won't have problems if you want to take this
off-list.
Best regards,
--
L. Alberto Giménez
JabberID agimenez@jabber•sysvalve.es
GnuPG key ID 0x3BAABDE1
next prev parent reply other threads:[~2011-05-02 21:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-01 11:00 [PATCH] ipheth.c: Enable IP header alignment L. Alberto Giménez
[not found] ` <1304247656-21086-1-git-send-email-agimenez-lqZFv/KUvpAxAGwisGp4zA@public.gmane.org>
2011-05-01 15:46 ` Ben Hutchings
2011-05-02 19:35 ` L. Alberto Giménez
2011-05-02 19:46 ` David Miller
2011-05-02 21:12 ` L. Alberto Giménez [this message]
2011-05-02 21:04 ` Ben Hutchings
2011-05-03 16:57 ` L. Alberto Giménez
[not found] ` <20110503165751.GA6566-vFZw08TITM7wxNmfbb4FQRs6BjWItJ1b@public.gmane.org>
2011-05-03 17:18 ` David Hill
2011-05-03 17:33 ` Paul McEnery
2011-05-03 17:41 ` David Hill
2011-05-03 22:45 ` Paul McEnery
2011-05-03 17:49 ` [PATCH net-next-2.6] ipheth: Properly distinguish length and alignment in URBs and skbs Ben Hutchings
2011-05-08 22:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502211245.GA18334@bart.evergreen.loc \
--to=agimenez@sysvalve$(echo .)es \
--cc=davem@davemloft$(echo .)net \
--cc=david.hill@ubisoft$(echo .)com \
--cc=dborca@yahoo$(echo .)com \
--cc=dgiagio@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pmcenery@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox