Subject: Re: [PATCH 1/2] usbnet: Style cleanups

From: Oliver Neukum <[email-masked]>
Date: Tue, 3 May 2011 20:49:41 +0200

Am Dienstag, 3. Mai 2011, 20:17:57 schrieb Joe Perches:
>  drivers/net/usb/usbnet.c |  625 +++++++++++++++++++++++----------------------
>  1 files changed, 319 insertions(+), 306 deletions(-)
> 
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 7bc9852..28aecbb 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -30,8 +30,8 @@
>   * issues can usefully be addressed by this framework.
>   */
>  
> -// #define     DEBUG                   // error path messages, extra info
> -// #define     VERBOSE                 // more; success messages
> +/* #define     DEBUG                   // error path messages, extra info */
> +/* #define     VERBOSE                 // more; success messages */

Hi,

1. please don't touch things like that. They are not comments in a semantic sense
2. If you are touching comments, please redo the multiline comments according to
the coding style.
3. please delay these modifications until the patches against the oom problem have
been applied

	Regards
		Oliver

-- 
- - - 
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) 
Maxfeldstraße 5                         
90409 Nürnberg 
Germany 
- - -