Subject: Re: [PATCHv3] net: Define enum for the bits used in features.

From: "Michael S. Tsirkin" <[email-masked]>
Date: Mon, 6 Jun 2011 23:35:15 +0300

On Mon, Jun 06, 2011 at 12:20:59PM -0700, David Miller wrote:
> From: "Michael S. Tsirkin" <[email-masked]>
> Date: Mon, 6 Jun 2011 18:32:53 +0300
> 
> > On Sun, Jun 05, 2011 at 10:15:37PM -0700, David Miller wrote:
> >> Since the GSO accessors deal with mutliple bits, you can create
> >> special GSO specific interfaces to manipulate them.
> > 
> > Yes but it's not just GSO.
> > It's anything that includes more than 1 feature.
> > Examples:
> > NETIF_F_ALL_CSUM
> > NETIF_F_ALL_TX_OFFLOADS
> > NETIF_F_V6_CSUM
> > NETIF_F_SOFT_FEATURES
> > 
> > etc
> > 
> > Creating many accessors for each will need a lot
> > of code duplication ...
> 
> Yet this is something you must resolve in order to change the feature
> bit implementation.
> 
> Whether this issue is difficult or not to address, it has to be done
> either way.

I think I found a truly elegant solution to this
problem which this margin is too narrow to contain ...

-- 
MST