Subject: Re: [PATCH 10/14] netvm: Set PF_MEMALLOC as appropriate during SKB processing

From: Mel Gorman <[email-masked]>
Date: Thu, 9 Jun 2011 12:35:05 +0100

On Thu, Jun 09, 2011 at 12:21:31PM +0200, Micha? Miros?aw wrote:
> 2011/6/9 Mel Gorman <[email-masked]>:
> [...]
> > +/*
> > + * Limit which protocols can use the PFMEMALLOC reserves to those that are
> > + * expected to be used for communication with swap.
> > + */
> > +static bool skb_pfmemalloc_protocol(struct sk_buff *skb)
> > +{
> > +       switch (skb->protocol) {
> > +       case __constant_htons(ETH_P_ARP):
> > +       case __constant_htons(ETH_P_IP):
> > +       case __constant_htons(ETH_P_IPV6):
> > +       case __constant_htons(ETH_P_8021Q):
> > +               return true;
> > +       default:
> > +               return false;
> > +       }
> > +}
> 
> This is not needed and wrong. Whatever list there will be, it's going
> to always miss some obscure setup (or not that obscure, like
> ATAoverEthernet).
> 

NBD is updated in the series to set the socket information
appropriately but the same cannot be said of AoE. The necessary
changes have been made IPv4 and IPv6 to handle pfmemalloc sockets
but the same cannot be necessarily said for the other protocols. Yes,
the check could be removed but leaving it there makes a clear statement
on what scenario can be reasonably expected to work.

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email-masked].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email-masked]"> [email-masked] </a>