From: Arnd Bergmann <arnd@arndb•de>
To: linux-arm-kernel@lists•infradead.org
Cc: Greg Ungerer <gerg@snapgear•com>,
Shawn Guo <shawn.guo@linaro•org>,
patches@linaro•org, netdev@vger•kernel.org,
devicetree-discuss@lists•ozlabs.org,
Jason Liu <jason.hui@linaro•org>,
linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH 2/3] net/fec: add device tree support
Date: Sun, 19 Jun 2011 14:11:31 +0200 [thread overview]
Message-ID: <201106191411.32137.arnd@arndb.de> (raw)
In-Reply-To: <4DFDDFF4.8000305@snapgear.com>
On Sunday 19 June 2011 13:39:32 Greg Ungerer wrote:
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id fec_dt_ids[] = {
> > + { .compatible = "fsl,fec", .data =&fec_devtype[0], },
> > + {},
> > +};
> > +
> > +static const struct of_device_id *
> > +fec_get_of_device_id(struct platform_device *pdev)
> > +{
> > + return of_match_device(fec_dt_ids,&pdev->dev);
> > +}
> > +#else
> > +#define fec_dt_ids NULL
> > +static inline struct of_device_id *
> > +fec_get_of_device_id(struct platform_device *pdev)
> > +{
> > + return NULL;
> > +}
> > +#endif
> > +
> > static unsigned char macaddr[ETH_ALEN];
> > module_param_array(macaddr, byte, NULL, 0);
> > MODULE_PARM_DESC(macaddr, "FEC Ethernet MAC address");
> > @@ -1363,6 +1385,11 @@ fec_probe(struct platform_device *pdev)
> > struct net_device *ndev;
> > int i, irq, ret = 0;
> > struct resource *r;
> > + const struct of_device_id *of_id;
> > +
> > + of_id = fec_get_of_device_id(pdev);
>
> fec_get_of_device_id() is defined inside of "#ifdef CONFIG_OF". This
> use of it will break compilation when this is not defined.
>
Why? Note the #else path defining an empty function.
Arnd
next prev parent reply other threads:[~2011-06-19 12:11 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 15:19 [PATCH 0/3] Add basic device support for imx51 babbage Shawn Guo
[not found] ` <1308410354-21387-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-06-18 15:19 ` [PATCH 1/3] serial/imx: add device tree support Shawn Guo
[not found] ` <1308410354-21387-2-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-06-18 16:19 ` Grant Likely
2011-06-19 7:02 ` Wolfram Sang
2011-06-19 7:30 ` Shawn Guo
2011-06-19 15:05 ` Grant Likely
2011-06-19 15:15 ` Rob Herring
2011-06-19 18:44 ` Grant Likely
2011-06-21 13:55 ` Shawn Guo
2011-06-21 18:32 ` Mitch Bradley
2011-06-21 18:42 ` Grant Likely
2011-06-21 18:53 ` Russell King - ARM Linux
2011-06-21 19:02 ` Grant Likely
[not found] ` <BANLkTiny9xDwiUww9Ys+jQZ0SHdQATABUA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-21 19:04 ` Mitch Bradley
2011-06-21 19:13 ` Grant Likely
[not found] ` <BANLkTim4vunTm1176MRw3pqRZnunu4=9jg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-21 19:35 ` Mitch Bradley
2011-06-21 19:38 ` Grant Likely
2011-06-21 22:08 ` Mitch Bradley
2011-06-21 22:33 ` Grant Likely
[not found] ` <BANLkTikBUo3jO=R0amkdxU1V3QMJoOUkEw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-21 22:52 ` Segher Boessenkool
[not found] ` <ba379b3b42f1659f4f6649c78b8bb1b2-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-06-21 22:58 ` Grant Likely
2011-06-22 15:33 ` Shawn Guo
2011-06-22 15:52 ` Grant Likely
[not found] ` <BANLkTimsk2eWKPi2hnHbaAn-vSMKmdYsGQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-23 0:12 ` Shawn Guo
[not found] ` <20110623001234.GB25799-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-06-23 3:35 ` Grant Likely
2011-06-23 18:38 ` Shawn Guo
2011-06-23 23:11 ` Grant Likely
[not found] ` <BANLkTi=8Mks6T85WnEyihmB21U1j7reHrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-24 3:49 ` Shawn Guo
[not found] ` <20110624034859.GB19188-+NayF8gZjK2ctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2011-06-24 4:05 ` Grant Likely
2011-06-18 16:21 ` Arnd Bergmann
[not found] ` <201106181821.46574.arnd-r2nGTMty4D4@public.gmane.org>
2011-06-18 16:26 ` Grant Likely
[not found] ` <20110618162655.GK8195-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-06-18 18:11 ` Arnd Bergmann
2011-06-19 7:41 ` Shawn Guo
2011-06-19 7:40 ` Shawn Guo
2011-06-18 15:19 ` [PATCH 2/3] net/fec: " Shawn Guo
2011-06-18 16:22 ` Grant Likely
[not found] ` <20110618162220.GI8195-e0URQFbLeQY2iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2011-06-19 7:46 ` Shawn Guo
[not found] ` <1308410354-21387-3-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-06-18 18:27 ` Arnd Bergmann
[not found] ` <201106182027.22974.arnd-r2nGTMty4D4@public.gmane.org>
2011-06-19 0:24 ` Grant Likely
2011-06-19 7:55 ` Shawn Guo
2011-06-19 11:39 ` Greg Ungerer
2011-06-19 12:11 ` Arnd Bergmann [this message]
2011-06-19 15:09 ` Rob Herring
2011-06-19 18:43 ` Grant Likely
2011-06-20 0:05 ` Greg Ungerer
2011-06-18 15:19 ` [PATCH 3/3] ARM: mx5: add basic device tree support for imx51 babbage Shawn Guo
[not found] ` <1308410354-21387-4-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-06-18 16:24 ` Grant Likely
2011-06-18 16:29 ` [PATCH 0/3] Add basic device " Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106191411.32137.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree-discuss@lists$(echo .)ozlabs.org \
--cc=gerg@snapgear$(echo .)com \
--cc=jason.hui@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=patches@linaro$(echo .)org \
--cc=shawn.guo@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox