From: Robin Holt <holt-sJ/iWh9BUns@public•gmane.org>
To: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public•gmane.org>,
Kumar Gala
<galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public•gmane.org>,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public•gmane.org>,
Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public•gmane.org>,
PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public•gmane.org>
Subject: Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.
Date: Wed, 10 Aug 2011 09:15:50 -0500 [thread overview]
Message-ID: <20110810141550.GQ4926@sgi.com> (raw)
In-Reply-To: <4E428BFF.7060402-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote:
> Hi Robin,
>
> On 08/10/2011 05:06 AM, Robin Holt wrote:
> > In working with the socketcan developers, we have come to the conclusion
> > the Documentation...fsl-flexcan.txt device tree documentation needs to
> > be cleaned up. The driver does not depend upon any properties other
>
> Your first sentence could be misleading. Please just describe what the
> patch does and why, something like:
>
> "This patch cleans up the documentation of the device-tree binding for
> the Flexcan devices on Freescale's PowerPC and ARM cores. Extra
> properties are not needed as the frequency of the source clock is
> fixed..." and so on.
I borrowed heavily from your message. ;)
> > than the required properties so we are removing the file. Additionally,
> > the p1010*dts* files are not following the standard for node naming in
> > that they have a trailing -v1.0.
>
> > Signed-off-by: Robin Holt <holt-sJ/iWh9BUns@public•gmane.org>
> > To: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public•gmane.org>,
> > To: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public•gmane.org>,
> > To: U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public•gmane.org>
> > To: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public•gmane.org>
> > Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public•gmane.org,
> > Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
> > Cc: PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public•gmane.org>
> > Cc: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public•gmane.org>
> > ---
> > .../devicetree/bindings/net/can/fsl-flexcan.txt | 61 --------------------
> > arch/powerpc/boot/dts/p1010rdb.dts | 8 ---
> > arch/powerpc/boot/dts/p1010si.dtsi | 8 +-
> > 3 files changed, 4 insertions(+), 73 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > deleted file mode 100644
> > index 1a729f0..0000000
> > --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> > +++ /dev/null
> > @@ -1,61 +0,0 @@
> > -CAN Device Tree Bindings
> > -------------------------
> > -2011 Freescale Semiconductor, Inc.
> > -
> > -fsl,flexcan-v1.0 nodes
> > ------------------------
> > -In addition to the required compatible-, reg- and interrupt-properties, you can
> > -also specify which clock source shall be used for the controller.
> > -
> > -CPI Clock- Can Protocol Interface Clock
> > - This CLK_SRC bit of CTRL(control register) selects the clock source to
> > - the CAN Protocol Interface(CPI) to be either the peripheral clock
> > - (driven by the PLL) or the crystal oscillator clock. The selected clock
> > - is the one fed to the prescaler to generate the Serial Clock (Sclock).
> > - The PRESDIV field of CTRL(control register) controls a prescaler that
> > - generates the Serial Clock (Sclock), whose period defines the
> > - time quantum used to compose the CAN waveform.
> > -
> > -Can Engine Clock Source
> > - There are two sources for CAN clock
> > - - Platform Clock It represents the bus clock
> > - - Oscillator Clock
> > -
> > - Peripheral Clock (PLL)
> > - --------------
> > - |
> > - --------- -------------
> > - | |CPI Clock | Prescaler | Sclock
> > - | |---------------->| (1.. 256) |------------>
> > - --------- -------------
> > - | |
> > - -------------- ---------------------CLK_SRC
> > - Oscillator Clock
> > -
> > -- fsl,flexcan-clock-source : CAN Engine Clock Source.This property selects
> > - the peripheral clock. PLL clock is fed to the
> > - prescaler to generate the Serial Clock (Sclock).
> > - Valid values are "oscillator" and "platform"
> > - "oscillator": CAN engine clock source is oscillator clock.
> > - "platform" The CAN engine clock source is the bus clock
> > - (platform clock).
> > -
> > -- fsl,flexcan-clock-divider : for the reference and system clock, an additional
> > - clock divider can be specified.
> > -- clock-frequency: frequency required to calculate the bitrate for FlexCAN.
> > -
> > -Note:
> > - - v1.0 of flexcan-v1.0 represent the IP block version for P1010 SOC.
> > - - P1010 does not have oscillator as the Clock Source.So the default
> > - Clock Source is platform clock.
> > -Examples:
> > -
> > - can0@1c000 {
> > - compatible = "fsl,flexcan-v1.0";
> > - reg = <0x1c000 0x1000>;
> > - interrupts = <48 0x2>;
> > - interrupt-parent = <&mpic>;
> > - fsl,flexcan-clock-source = "platform";
> > - fsl,flexcan-clock-divqider = <2>;
> > - clock-frequency = <fixed by u-boot>;
> > - };
>
> Do we really want to drop the documentation for that binding. I think
> something like the following text would be still useful:
>
> ------------------------
> Flexcan CAN contoller on Freescale's ARM and PowerPC processors
>
> Required properties:
>
> - compatible : Should be "fsl,flexcan" and optionally
> "fsl,flexcan-<processor>"
> - reg : Offset and length of the register set for this device
> - interrupts : Interrupt tuple for this device
>
> Example:
>
> can@1c000 {
> compatible = "fsl,p1010-flexcan", "fsl,flexcan";
> reg = <0x1c000 0x1000>;
> interrupts = <48 0x2>;
> interrupt-parent = <&mpic>;
> };
> -------------------------
Done, except the
> compatible = "fsl,p1010-flexcan", "fsl,flexcan";
line is
compatible = "fsl,flexcan", "fsl,flexcan-p1010";
>
> What do you think?
>
> > diff --git a/arch/powerpc/boot/dts/p1010rdb.dts b/arch/powerpc/boot/dts/p1010rdb.dts
> > index 6b33b73..d6a0bb2 100644
> > --- a/arch/powerpc/boot/dts/p1010rdb.dts
> > +++ b/arch/powerpc/boot/dts/p1010rdb.dts
> > @@ -169,14 +169,6 @@
> > };
> > };
> >
> > - can0@1c000 {
> > - fsl,flexcan-clock-source = "platform";
> > - };
> > -
> > - can1@1d000 {
> > - fsl,flexcan-clock-source = "platform";
> > - };
> > -
> > usb@22000 {
> > phy_type = "utmi";
> > };
> > diff --git a/arch/powerpc/boot/dts/p1010si.dtsi b/arch/powerpc/boot/dts/p1010si.dtsi
> > index 7f51104..20c396d 100644
> > --- a/arch/powerpc/boot/dts/p1010si.dtsi
> > +++ b/arch/powerpc/boot/dts/p1010si.dtsi
> > @@ -141,19 +141,19 @@
> > };
> >
> > can0@1c000 {
> > - compatible = "fsl,flexcan-v1.0";
> > + compatible = "fsl,p1010-flexcan",
> > + "fsl,flexcan";
>
> Does fit on one line.
>
> > reg = <0x1c000 0x1000>;
> > interrupts = <48 0x2>;
> > interrupt-parent = <&mpic>;
> > - fsl,flexcan-clock-divider = <2>;
> > };
> >
> > can1@1d000 {
> > - compatible = "fsl,flexcan-v1.0";
> > + compatible = "fsl,p1010-flexcan",
> > + "fsl,flexcan";
>
> Ditto
>
> > reg = <0x1d000 0x1000>;
> > interrupts = <61 0x2>;
> > interrupt-parent = <&mpic>;
> > - fsl,flexcan-clock-divider = <2>;
> > };
> >
> > L2: l2-cache-controller@20000 {
>
> Please also correct the node names (not using the number suffix).
So the node names should be
can@1c000 {
can@1d000 {
correct?
Robin
next prev parent reply other threads:[~2011-08-10 14:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 3:05 [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) Robin Holt
[not found] ` <1312945564-6626-1-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-10 3:06 ` [PATCH v10 1/5] [flexcan] Remove #include <mach/clock.h> Robin Holt
2011-08-10 3:06 ` [PATCH v10 2/5] [flexcan] Abstract off read/write for big/little endian Robin Holt
2011-08-10 3:06 ` [PATCH v10 3/5] [flexcan] Add of_match to platform_device definition Robin Holt
[not found] ` <1312945564-6626-4-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-10 14:33 ` Robin Holt
2011-08-10 3:06 ` [PATCH v10 4/5] [powerpc] Add flexcan device support for p1010rdb Robin Holt
[not found] ` <1312945564-6626-5-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-10 9:56 ` Marc Kleine-Budde
[not found] ` <4E4255B1.6050001-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-10 10:15 ` Robin Holt
2011-08-10 3:06 ` [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding Robin Holt
[not found] ` <1312945564-6626-6-git-send-email-holt-sJ/iWh9BUns@public.gmane.org>
2011-08-10 8:15 ` Robert Schwebel
2011-08-10 13:47 ` Wolfgang Grandegger
[not found] ` <4E428BFF.7060402-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-10 14:15 ` Robin Holt [this message]
2011-08-10 14:36 ` U Bhaskar-B22300
[not found] ` <9C64B7751C3BCA41B64A68E23005A7BE1C6A21-TcFNo7jSaXPiTqIcKZ1S2K4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-08-10 16:00 ` Robin Holt
[not found] ` <20110810160054.GT4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 16:53 ` Kumar Gala
[not found] ` <63306A24-3FBF-4DAA-A0B9-6005F56BB76F-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-08-10 17:16 ` Robin Holt
[not found] ` <20110810171600.GV4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 17:17 ` Kumar Gala
[not found] ` <8C9817C6-735D-4B7C-A03B-5661C04C725A-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-08-10 17:20 ` Robin Holt
[not found] ` <20110810172040.GX4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 17:26 ` Kumar Gala
2011-08-10 18:23 ` Wolfgang Grandegger
2011-08-10 18:27 ` Scott Wood
[not found] ` <4E42CDA8.5050902-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-08-10 18:35 ` Robin Holt
2011-08-10 18:39 ` Scott Wood
[not found] ` <20110810141550.GQ4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 14:41 ` Wolfgang Grandegger
[not found] ` <4E42987F.9040304-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-08-10 14:46 ` Kumar Gala
2011-08-10 14:45 ` Kumar Gala
[not found] ` <8ED8063F-7227-402A-89D5-7CE69241AF9C-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-08-10 15:35 ` Robin Holt
2011-08-10 10:09 ` Robin Holt
2011-08-10 10:01 ` [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) Marc Kleine-Budde
[not found] ` <4E425716.4010104-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-08-10 10:11 ` Robin Holt
[not found] ` <20110810101113.GN4926-sJ/iWh9BUns@public.gmane.org>
2011-08-10 10:24 ` Marc Kleine-Budde
2011-08-10 11:09 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810141550.GQ4926@sgi.com \
--to=holt-sj/iwh9buns@public$(echo .)gmane.org \
--cc=B22300-KZfg59tc24xl57MIdRCFDg@public$(echo .)gmane.org \
--cc=galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public$(echo .)gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public$(echo .)gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=scottwood-KZfg59tc24xl57MIdRCFDg@public$(echo .)gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public$(echo .)gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox