From: Jiri Pirko <jpirko@redhat•com>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: bugme-daemon@bugzilla•kernel.org, netdev@vger•kernel.org,
mike.auty@gmail•com
Subject: Re: [Bugme-new] [Bug 41152] New: kernel 3.0 and above fails to handle vlan id 0 (802.1p) packets properly without hardware acceleration
Date: Wed, 17 Aug 2011 07:37:38 +0200 [thread overview]
Message-ID: <20110817053737.GA1936@minipsycho> (raw)
In-Reply-To: <20110816150918.5b2d7067.akpm@linux-foundation.org>
Wed, Aug 17, 2011 at 12:09:18AM CEST, akpm@linux-foundation•org wrote:
>
>(switched to email. Please respond via emailed reply-to-all, not via the
>bugzilla web interface).
>
>On Sun, 14 Aug 2011 12:48:16 GMT
>bugzilla-daemon@bugzilla•kernel.org wrote:
>
>> https://bugzilla.kernel.org/show_bug.cgi?id=41152
>>
>> Summary: kernel 3.0 and above fails to handle vlan id 0
>> (802.1p) packets properly without hardware
>> acceleration
>> Product: Networking
>> Version: 2.5
>> Kernel Version: 3.0
>> Platform: All
>> OS/Version: Linux
>> Tree: Mainline
>> Status: NEW
>> Severity: normal
>> Priority: P1
>> Component: Other
>> AssignedTo: acme@ghostprotocols•net
>> ReportedBy: mike.auty@gmail•com
>> Regression: Yes
>>
>>
>> Hi there,
>>
>> I recently found that packets tagged with a vlan id of 0 are no longer received
>> on the main interface. There were no dmesg entries on the dropped packets. I
>> attempted to setup a vlan 0 interface and configure it, but couldn't
>> successfully route traffic to the device. I can recreate this on two of the
>> three networking devices I have, my guess is that the third does successfully
>> handle hardware acceleration of vlan tags.
>>
>> After a bisection this appears to be related to commit
>> bcc6d47903612c3861201cc3a866fb604f26b8b2, which seems to try to merge the
>> non-hardware accelerated and hardware accelerated code paths for handling
>> vlans. In the process, it appears vlan id 0 (802.1p) packets are no longer
>> handled correctly.
>>
>> Unfortunately I don't know the code paths well enough to figure out what's
>> going wrong, but I'd be happy to provide more information, run tests or try out
>> patches if it would help, just let me know. Thanks... 5:)
>>
>> Mike 5:)
Hi Mike. May I ask what NIC are you seeing the regression on?
It may have something to do with dev->vlangrp and ndo_vlan_add/kill_vid.
VID 0 was recently only added by the latter ones. So if driver only
depended on dev->vlangrp, 0 was not there. This was changed recently by
my "vlan cleanup" patches. It may work for you again on net-next today.
Jirka
>
next prev parent reply other threads:[~2011-08-17 5:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-41152-10286@https.bugzilla.kernel.org/>
2011-08-16 22:09 ` [Bugme-new] [Bug 41152] New: kernel 3.0 and above fails to handle vlan id 0 (802.1p) packets properly without hardware acceleration Andrew Morton
2011-08-17 5:37 ` Jiri Pirko [this message]
2011-08-17 6:36 ` Mike Auty
2011-08-17 10:59 ` Jiri Pirko
2011-08-17 17:50 ` Jiri Pirko
2011-08-17 22:48 ` Mike Auty
2011-08-18 16:37 ` Jiri Pirko
2011-08-18 19:39 ` Mike Auty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817053737.GA1936@minipsycho \
--to=jpirko@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=bugme-daemon@bugzilla$(echo .)kernel.org \
--cc=mike.auty@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox