Subject: Re: [PATCH 7/7] bnx2x: expose HW RX VLAN stripping toggle

From: Michal Schmidt <[email-masked]>
Date: Wed, 31 Aug 2011 17:51:20 +0200

On Wed, 31 Aug 2011 17:37:49 +0200 Michal Schmidt wrote:
> I could restore dev->features before
> returning if bnx2x_reload_if_running() fails.

Or even safer - restore them always:
	...
	u32 orig_features = dev->features;
	dev->features = features;
        ret = bnx2x_reload_if_running(dev);
        dev->features = orig_features;
        return ret;
	...
This way we don't have to assume anything about
__netdev_update_features().

Michal